Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(docs): remove redundant code in the tutorial section #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

tinti
Copy link
Contributor

@tinti tinti commented Jul 18, 2023

Issue number: #2803

Summary

Simplifies redundant code in documentation.

Changes

Please provide a summary of what's being changed

Removed redundant statement:

subsegment.put_annotation(key="ColdStart", value=cold_start)

The code can be even further simplified by removing the if statement and always setting cold_start = False.

User experience

Please share what the user experience looks like before and after this change

Improved readability.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@tinti tinti requested a review from a team July 18, 2023 15:10
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jul 18, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 18, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 18, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@tinti tinti changed the title fix(docs) remove redundant code fix(docs): remove redundant code Jul 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@heitorlessa heitorlessa requested a review from rubenfonseca July 20, 2023 11:19
@rubenfonseca rubenfonseca linked an issue Jul 20, 2023 that may be closed by this pull request
1 task
@rubenfonseca rubenfonseca self-assigned this Jul 20, 2023
@rubenfonseca
Copy link
Contributor

Looking at this now. I've started by creating the necessary Issue first to link to this issue.

@github-actions github-actions bot added the bug Something isn't working label Jul 20, 2023
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you for this!

@rubenfonseca rubenfonseca merged commit d8cfe51 into aws-powertools:develop Jul 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@rubenfonseca rubenfonseca changed the title fix(docs): remove redundant code fix(docs): remove redundant code in the tutorial section Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Refresh tutorial code
3 participants