Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(event_source): fix typo in physicalname attribute for AmazonMQ events #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

SZubarev
Copy link
Contributor

@SZubarev SZubarev commented Apr 1, 2024

Issue number: #4051

Summary

Fixed a typo in attribute name of ActiveMQ event of AmazonMQ event integration

Changes

Fixed typo in attribute name

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@SZubarev SZubarev requested a review from a team April 1, 2024 22:35
Copy link

boring-cyborg bot commented Apr 1, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2024
@leandrodamascena leandrodamascena changed the title Fix bug #4051 fix(event_source): fix typo in physicalname attribute for AmazonMQ events Apr 2, 2024
@leandrodamascena leandrodamascena linked an issue Apr 2, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Apr 2, 2024

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge need-issue PRs that are missing related issues bug Something isn't working labels Apr 2, 2024
@leandrodamascena leandrodamascena removed do-not-merge need-issue PRs that are missing related issues labels Apr 2, 2024
@boring-cyborg boring-cyborg bot added the tests label Apr 2, 2024
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2024
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick work, @SZubarev!

APPROVED!

@leandrodamascena leandrodamascena merged commit 0f4177b into aws-powertools:develop Apr 2, 2024
19 checks passed
Copy link

boring-cyborg bot commented Apr 2, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Error parsing AmazonMQ message
3 participants