fix(event_source): fix HomeDirectoryDetails type in TransferFamilyAuthorizerResponse method #6403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wrong type for home_directory_details
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6403 +/- ##
========================================
Coverage 96.31% 96.31%
========================================
Files 242 242
Lines 11710 11711 +1
Branches 871 871
========================================
+ Hits 11279 11280 +1
Misses 337 337
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
approved these changes
Apr 4, 2025
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
leandrodamascena
pushed a commit
that referenced
this pull request
Apr 24, 2025
…horizerResponse method (#6403) fix(dataclass): TransferFamilyAuthorizerResponse build method return wrong type for home_directory_details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #6396
Summary
Changes
This PR resolve an issue with the return type of the parameter HomeDirectoryDetails from the _build_authentication_response() method in TransferFamilyAuthorizerResponse.
User experience
Before this PR, the AWS Transfer Server return an error : "Unable to parse Json", when HomeDirectoryDetails was set.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.