fix(logger): warn customers when the ALC log level is less verbose than log buffer #6509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6509 +/- ##
===========================================
- Coverage 96.16% 96.14% -0.03%
===========================================
Files 243 243
Lines 11836 11844 +8
Branches 881 885 +4
===========================================
+ Hits 11382 11387 +5
- Misses 358 359 +1
- Partials 96 98 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leandrodamascena
requested changes
Apr 17, 2025
There was a problem hiding this comment.
Hey @anafalcao! Thanks a lot for this PR, please just check my comments!
tests/functional/logger/required_dependencies/test_powertools_logger_buffer.py
Outdated
Show resolved
Hide resolved
|
2 tasks
leandrodamascena
approved these changes
Apr 17, 2025
leandrodamascena
added a commit
that referenced
this pull request
Apr 24, 2025
…an log buffer (#6509) * fix(logger): warn customers when the ALC log level is less verbose than log buffer * change flush buffer warning * mypy * mypy * mypy * fix logger * change flush buffer warn * check buffer config --------- Co-authored-by: Leandro Damascena <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #6440
Summary
When the Advanced Logging Control is less verbose than the Logger Log buffer, buffered logs will not be visible. This PR adds a warning that is emitted when this scenario is detected.
There's an existing warning message if the ALC Log Level is less verbose than the Logger Log Level.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.