Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: a more polite closed issue message #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: a more polite closed issue message #1954

wants to merge 1 commit into from

Conversation

kellertk
Copy link

Description of your changes

In the AWS SDKs, we received some customer feedback that the closed issue message is too loud and too full of emoji. You use the same message. This message is slightly more polite. If you disagree, please discard this PR.

Related issues, RFCs

Issue number:
None

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@kellertk kellertk requested a review from a team January 24, 2024 21:57
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jan 24, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 24, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jan 24, 2024

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dreamorosi
Copy link
Contributor

Hi @kellertk, thanks for opening this PR.

I'm going to put this on hold for now and will be following the discussion in aws-powertools/powertools-lambda-python#3671 before deciding whether to merge it or not since we share the same concerns expressed there.

Also in the future please consider familiarizing yourself with the project's contribution guidelines, specifically around discussing changes in an issue before sending a PR.

@dreamorosi dreamorosi added on-hold This item is on-hold and will be revisited in the future do-not-merge This item should not be merged labels Jan 25, 2024
@dreamorosi
Copy link
Contributor

As discussed in the linked PR, we'll be refactoring our automations in the coming months and we'll take the opportunity to reword this message then.

Thank you for opening this PR anyway.

@dreamorosi dreamorosi closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automation This item relates to automation do-not-merge This item should not be merged on-hold This item is on-hold and will be revisited in the future size/XS PR between 0-9 LOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kellertk @dreamorosi