Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Security Vulnerabilities, Test Warnings, and -SNAPSHOT to version #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2023
Merged

Security Vulnerabilities, Test Warnings, and -SNAPSHOT to version #234

merged 1 commit into from
Oct 11, 2023

Conversation

@brendan-p-lynch
Copy link

@brendan-p-lynch brendan-p-lynch commented Oct 11, 2023

Bumps netty-handler from 4.1.86.Final to 4.1.94.Final.
Bumps protobuf-java from 3.21.5 to 3.21.7.
Bumps jackson-databind from 2.13.4 to 2.13.5.

Added -SNAPSHOT to version for better version tracking

Fixed test warnings by escaping \

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updated versions for security vulnerabilities, added -SNAPSHOT in ver…
03f3e36 
…sion, and fixed test warning with escape character
@brendan-p-lynch brendan-p-lynch merged commit e9b81f1 into awslabs:master Oct 11, 2023
@loewen1
Copy link

loewen1 commented Nov 21, 2023

@brendan-p-lynch please add a proper release tag for v2.1.4-SNAPSHOT

@brendan-p-lynch
Copy link
Author

brendan-p-lynch commented Nov 21, 2023

@brendan-p-lynch please add a proper release tag for v2.1.4-SNAPSHOT

The "-SNAPSHOT" is intended to indicate that this is not a proper release. This is the version that we will be iterating on over time in between official releases, so the tag would be antithetical to the purpose of the versioning

@loewen1
Copy link

loewen1 commented Nov 21, 2023

@brendan-p-lynch please add a proper release tag for v2.1.4-SNAPSHOT

The "-SNAPSHOT" is intended to indicate that this is not a proper release. This is the version that we will be iterating on over time in between official releases, so the tag would be antithetical to the purpose of the versioning

The problem is that setuptools doesn't allow the package version with -SNAPSHOT. 2.1.4rc1 should be used instead for a release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akidambisrinivasan akidambisrinivasan akidambisrinivasan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brendan-p-lynch @loewen1 @akidambisrinivasan