Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[fix] h2 stream manager initial settings not passed correctly & Log the headers #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TingDaoK wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[fix] h2 stream manager initial settings not passed correctly & Log the headers #544

TingDaoK wants to merge 3 commits into from

Conversation

@TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Jan 28, 2026 •
edited
Loading

Issue #, if available:

  1. When the initial settings set for h2 stream manager, the copy of the initial settings has a bug that didn't set the length of array correctly after the data copied. And end with the initial settings was not respected.
  2. When converting http/1.1 header to h2, forget to skip connection header that is also not allowed
  3. An endpoint MUST NOT generate an HTTP/2 message containing connection-specific header fields. so that let's check the headers we send out, and error out if those headers are found

Description of changes:

  • Add tests. Also, issues warnings when the flow control window is 0 and stops the flow so that we can track this easier
  • Fix the headers related bug
  • Log the headers so that we can debug easier
  • Skip the authorization headers in case of sensitive information.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.63%. Comparing base (acf3139) to head (ae7518c).

Files with missing lines Patch % Lines
source/h2_stream.c 60.00% 6 Missing ⚠️
source/h1_stream.c 80.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #544      +/-   ##
==========================================
- Coverage   79.70%   79.63%   -0.08%     
==========================================
  Files          28       28              
  Lines       11869    11892      +23     
==========================================
+ Hits         9460     9470      +10     
- Misses       2409     2422      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TingDaoK TingDaoK changed the title [fix] h2 stream manager initial settings not passed correctly [fix] h2 stream manager initial settings not passed correctly & Log the headers Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TingDaoK @codecov-commenter