Nbest reranking options using isometric translation criteria.#1048
Conversation
fhieber
left a comment
There was a problem hiding this comment.
Thanks for iterating, just 2 remaining comments.
| return obj_list | ||
|
|
||
|
|
||
| def count_seq_len(sample: str, count_type: str = 'char', replace_tokens: Optional[List] = None) -> int: |
There was a problem hiding this comment.
I think some unit tests would be useful for this.
I have added the tests. Thanks for the reviews and comments! |
|
@surafelml looks like there is still some linter error. |
|
style-check seems to throw an error on the inference script, which is not related with reranking module |
|
Are you sure? Is this an error you get locally? ************* Module sockeye.rerank |
|
i have checked it several times, after downgrading |
|
The failure in CI is not related to the issues you see locally. Sometimes it is difficult to replicate the environment of CI exactly locally. |
|
Yes, this must be a case the linter is confusing the arg structure in the partial functions. Adding type ignore show no change for the CI issue. Passing the |
|
|
|
local tests didn't catch mypy (same version) error as in CI for Literal. first option was to use set |
Added Nbest list reranking options using isometric translation criteria as proposed in an ICASSP 2021 paper https://arxiv.org/abs/2110.03847.
Pull Request Checklist
until you can check this box.
pytest)pytest test/system)./style-check.sh)sockeye/__init__.py. Major version bump if this is a backwards incompatible change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.