Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(http): preserve response in error when stream is aborted after headers #10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonsaayman merged 8 commits into from
Apr 28, 2026
+21 −6
Merged

fix(http): preserve response in error when stream is aborted after headers #10708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dc7a004
fix(http): preserve response in error when stream is aborted after he…
afurm Apr 14, 2026
adf3b09
Merge branch 'v1.x' into fix/stream-abort-preserve-response
jasonsaayman Apr 14, 2026
99ccf44
Merge branch 'v1.x' into fix/stream-abort-preserve-response
jasonsaayman Apr 25, 2026
81e8502
Merge branch 'v1.x' into fix/stream-abort-preserve-response
jasonsaayman Apr 25, 2026
47d5c57
fix(http): normalize response stream errors
afurm Apr 25, 2026
99a8bb6
Merge branch 'v1.x' into fix/stream-abort-preserve-response
jasonsaayman Apr 28, 2026
ac8b497
Merge branch 'v1.x' into fix/stream-abort-preserve-response
jasonsaayman Apr 28, 2026
1dfadfa
Merge branch 'v1.x' into fix/stream-abort-preserve-response
jasonsaayman Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/adapters/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,15 +904,16 @@ export default isHttpAdapterSupported &&
'stream has been aborted',
AxiosError.ERR_BAD_RESPONSE,
config,
lastRequest
lastRequest,
response
);
responseStream.destroy(err);
reject(err);
});

responseStream.on('error', function handleStreamError(err) {
if (req.destroyed) return;
reject(AxiosError.from(err, null, config, lastRequest));
reject(AxiosError.from(err, null, config, lastRequest, response));
});

responseStream.on('end', function handleStreamEnd() {
Expand Down
22 changes: 18 additions & 4 deletions tests/unit/adapters/http.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,17 +612,28 @@ describe('supports http with nodejs', () => {
it('should support gunzip error handling', async () => {
const server = await startHTTPServer(
(req, res) => {
res.statusCode = 206;
res.setHeader('Content-Type', 'application/json');
res.setHeader('Content-Encoding', 'gzip');
res.setHeader('X-Stream-Error', 'yes');
res.end('invalid response');
},
{ port: SERVER_PORT }
);

try {
await assert.rejects(async () => {
await axios.get(`http://localhost:${server.address().port}/`);
});
await assert.rejects(
async () => {
await axios.get(`http://localhost:${server.address().port}/`);
},
(error) => {
assert.strictEqual(error.response.status, 206);
assert.strictEqual(error.response.headers.get('x-stream-error'), 'yes');
assert.strictEqual(error.status, 206);

return true;
}
);
} finally {
await stopHTTPServer(server);
}
Expand Down Expand Up @@ -2692,7 +2703,7 @@ describe('supports http with nodejs', () => {
it('should throw an error if http server that aborts a chunked request', async () => {
const server = await startHTTPServer(
(req, res) => {
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.writeHead(200, { 'Content-Type': 'text/plain', 'X-Stream-Aborted': 'yes' });
res.write('chunk 1');

setTimeout(() => {
Expand All @@ -2714,6 +2725,9 @@ describe('supports http with nodejs', () => {
(error) => {
assert.strictEqual(error.code, 'ERR_BAD_RESPONSE');
assert.strictEqual(error.message, 'stream has been aborted');
assert.strictEqual(error.response.status, 200);
assert.strictEqual(error.response.headers.get('x-stream-aborted'), 'yes');
assert.strictEqual(error.status, 200);

return true;
}
Expand Down
Loading