refactor(helpers): optimize the logic of isAxiosError#3546
Merged
Conversation
1. add the judgment of null
eb21346 to
11c1825
Compare
JasonHK
approved these changes
Jan 14, 2021
JasonHK
left a comment
Contributor
There was a problem hiding this comment.
Thanks! 😄 I should use the isObject function in the first place.
Contributor
|
Nice! I just discovered this while writing tests for my codebase! Hope this will be merged soon! |
johachi
approved these changes
Apr 14, 2021
|
@jasonsaayman Could you take a look at this please? I just ran into an issue that this would fix (passing |
Contributor
|
The forgotten PR 😭 |
Member
|
No longer forgotten :) |
mbargiel
pushed a commit
to mbargiel/axios
that referenced
this pull request
Jan 27, 2022
1. add the judgment of null Co-authored-by: Jay <[email protected]>
This was referenced Feb 22, 2022
This was referenced Mar 9, 2022
This was referenced Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add the judgment of null