Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: unsettled promise when request is aborted and compression is used and maxRedirects is set to 0 #7149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonsaayman merged 3 commits into from
Apr 29, 2026
+23 −1
Merged

fix: unsettled promise when request is aborted and compression is used and maxRedirects is set to 0 #7149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0018977
chore: matches the sibling responseStream.on(aborted) handler and add…
jasonsaayman Apr 28, 2026
677d3a3
Merge branch 'v1.x' into bugfix/handle-closed-socket
jasonsaayman Apr 28, 2026
9fd728f
Merge branch 'v1.x' into bugfix/handle-closed-socket
jasonsaayman Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/adapters/http.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -912,7 +912,7 @@ export default isHttpAdapterSupported &&
});

responseStream.on('error', function handleStreamError(err) {
if (req.destroyed) return;
if (rejected) return;
reject(AxiosError.from(err, null, config, lastRequest, response));
});

Expand Down
22 changes: 22 additions & 0 deletions tests/unit/adapters/http.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,28 @@ describe('supports http with nodejs', () => {
await stopHTTPServer(server);
}
});

it('should reject when the server aborts mid-stream and maxRedirects is 0', async () => {
const server = await startHTTPServer(
async (req, res) => {
res.setHeader('Content-Encoding', type);
res.setHeader('Transfer-Encoding', 'chunked');
res.removeHeader('Content-Length');
res.write(await zipped);
setTimeout(() => res.socket.destroy(), 10);
},
{ port: SERVER_PORT }
);

try {
await assert.rejects(
axios.get(`http://localhost:${server.address().port}`, { maxRedirects: 0 }),
(err) => err && err.code === 'ECONNRESET'
);
} finally {
await stopHTTPServer(server);
}
});
});
}
});
Expand Down
Loading