fix: throw error for malformed URLs missing '//' #7315#7316
Open
sapla1125 wants to merge 1 commit intoaxios:v1.xfrom
Open
fix: throw error for malformed URLs missing '//' #7315#7316sapla1125 wants to merge 1 commit intoaxios:v1.xfrom
sapla1125 wants to merge 1 commit intoaxios:v1.xfrom
Conversation
shivarajnaidu
approved these changes
Jan 18, 2026
| import parseProtocol from '../../../lib/helpers/parseProtocol.js'; | ||
|
|
||
| // Minimal expect helper for browser testing | ||
| function expect(actual) { |
There was a problem hiding this comment.
Suggested change
| function expect(actual) { | |
| function expect(actual) { | |
Member
Contributor
|
@jasonsaayman I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes URL normalization in Axios by throwing an explicit error when a URL protocol is missing // instead of silently normalizing it.
Changes included:
Added validation in parseProtocol to detect malformed URLs.
Updated tests to cover invalid URLs like http:/example.com and https:/127.0.0.1/ to ensure they throw an error.
Updated documentation to mention that malformed URLs now throw explicitly.
Issue Reference:
Fixes #7315