remove ts type imports on Program:exit#10009
Open
tanhauhau wants to merge 2 commits intobabel:next-8-devfrom
Open
remove ts type imports on Program:exit#10009tanhauhau wants to merge 2 commits intobabel:next-8-devfrom
tanhauhau wants to merge 2 commits intobabel:next-8-devfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10841/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10829/ |
Member
|
Thanks! |
jeysal
reviewed
May 21, 2019
| // with this crawl, babel-plugin-transform-typescript | ||
| // used to elide the import we just added | ||
| // https://github.com/babel/babel/issues/7592 | ||
| path.scope.crawl(); |
Contributor
There was a problem hiding this comment.
Shouldn't we keep both crawls in? Without this one, the test no longer ensures that a plugin doing this works correctly and it could regress to eliding injected but not yet referenced imports
jeysal
approved these changes
May 22, 2019
Contributor
jeysal
left a comment
There was a problem hiding this comment.
Nice, LGTM as far as not eliding injected imports is concerned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fyi @jeysal