Avoid removing class fields using flow in plugin-transform-flow-strip-types plugin#10120
Merged
nicolo-ribaudo merged 3 commits intobabel:next-8-devfrom Feb 9, 2020
Merged
Avoid removing class fields using flow in plugin-transform-flow-strip-types plugin#10120nicolo-ribaudo merged 3 commits intobabel:next-8-devfrom
plugin-transform-flow-strip-types plugin#10120nicolo-ribaudo merged 3 commits intobabel:next-8-devfrom
Conversation
Member
|
Can you add the |
Contributor
Author
|
@nicolo-ribaudo okay cool. Let me try |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11033/ |
1 similar comment
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/11033/ |
Contributor
Author
|
@nicolo-ribaudo Thanks. I fixed it. |
Contributor
Author
|
@nicolo-ribaudo Kindly review these changes. |
Member
|
This PR looks good, but we will have to wait until v8 |
| "plugins": [ | ||
| "transform-flow-strip-types", | ||
| "transform-classes", | ||
| "@babel/plugin-proposal-class-properties", |
Member
There was a problem hiding this comment.
This should just be proposal-class-properties, to use the package from the monorepo and not from node_modules
5bc8ee6 to
8d674a3
Compare
nicolo-ribaudo
approved these changes
Feb 4, 2020
existentialism
approved these changes
Feb 4, 2020
Member
|
According to our e2e tests, this breaking change affects Babel itself 🙃 I'll fix it in |
5e5dfb8 to
e0b4781
Compare
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 9, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 9, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 13, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 20, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 23, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
JLHwung
pushed a commit
to JLHwung/babel
that referenced
this pull request
Feb 27, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Feb 27, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Mar 3, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Mar 10, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Mar 11, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Mar 13, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Mar 22, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 11, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 20, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
arku
pushed a commit
to arku/babel
that referenced
this pull request
Apr 20, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 21, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 21, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 22, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
May 8, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo
added a commit
that referenced
this pull request
May 9, 2020
* flow avoid removing class fields * fix test case * Update test Co-authored-by: Nicolò Ribaudo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10039Currently when using flow plugin
transform-flow-strip-typesremoves the uninitialize class fields, after this change we won't remove the uninitialize class fields. However they can remove usingignoreUninitializedoption mentioned here #9141