Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump Node support to >= 10.13#10747

Merged
nicolo-ribaudo merged 4 commits intobabel:next-8-devfrom
JLHwung:drop-node-8-support
Feb 6, 2020
Merged

Bump Node support to >= 10.13#10747
nicolo-ribaudo merged 4 commits intobabel:next-8-devfrom
JLHwung:drop-node-8-support

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 21, 2019 •
edited
Loading

Q                       A
Fixed Issues? Closes #9981
Major: Breaking Change? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? Dropped Node.js <10.13 support, use rollup-plugin-node-polyfills
License MIT

In this PR we drop Node.js < 10.13 support.

  • Update engines field in package.json
  • Update babel.config.js
  • Update CI config
  • Bump dependencies that requires node.js >= 10.13
  • remove ad-hoc polyfills for Node.js 6 and Node.js 8 in code base
  • remove minNodeVersion: "8.0.0" test case config
  • replace make-dir by fs.mkdir
  • replace node-environment-flags by process.allowedNodeEnvironmentFlags
  • chore: update acorn to v7.0.0 calvinmetcalf/rollup-plugin-node-globals#34

@JLHwung JLHwung added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Nov 21, 2019
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Nov 21, 2019
Open
34 tasks
@JLHwung JLHwung mentioned this pull request Nov 21, 2019
Closed
@kaicataldo
Copy link
Member

kaicataldo commented Nov 21, 2019

Do we also need to update the engines field in the individual packages? Or is that something we should do in a separate PR?

coreyfarrell
coreyfarrell reviewed Dec 14, 2019
View reviewed changes
@JLHwung JLHwung force-pushed the drop-node-8-support branch from b9486c0 to 2f566c1 Compare December 17, 2019 16:23
@JLHwung JLHwung changed the title Drop node < 10.9 support Bump Node support to >= 10.13 Dec 17, 2019
@JLHwung JLHwung force-pushed the drop-node-8-support branch from 700bc55 to 426971b Compare December 26, 2019 15:59
@milesj
Copy link

milesj commented Jan 22, 2020

Jest 25 just landed that updated chokidar to v3. Seems like Babel is the last one. Looking forward to this landing :)

@nicolo-ribaudo nicolo-ribaudo changed the base branch from master to next-8-dev February 3, 2020 23:38
nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to merge this as separate commits (using "Rebase and merge"):

  • Config update
  • Remove polyfills and minNodeVersion
  • Bump deps
  • Replace the rollup plugins with rollup-plugin-node-polyfills

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Feb 5, 2020
Closed
JLHwung and others added 4 commits February 6, 2020 16:23
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support
56f2a0a 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js
d54702d 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
@JLHwung @nicolo-ribaudo
Bump dependencies
0b736cd 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins
ddb35e4
@nicolo-ribaudo nicolo-ribaudo merged commit e3f045f into babel:next-8-dev Feb 6, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the drop-node-8-support branch February 6, 2020 17:37
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Feb 6, 2020

🎉

nicolo-ribaudo pushed a commit that referenced this pull request Feb 6, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
c6ee24d 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Feb 6, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
ad98d67 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Feb 6, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
5a10c0f 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Feb 6, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
eec4e36 
#10747)
nicolo-ribaudo added a commit that referenced this pull request Feb 6, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+builtins (#1…
08a1c8c 
…0747)
nicolo-ribaudo pushed a commit that referenced this pull request Feb 9, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
c91d69b 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Mar 10, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
daee5bd 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Mar 10, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
64ad4a2 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Mar 10, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
470dc06 
#10747)
nicolo-ribaudo pushed a commit that referenced this pull request Mar 11, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
a6f050a 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Mar 11, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
70c3db8 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Mar 11, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
d868289 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Mar 11, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
1985bdf 
#10747)
nicolo-ribaudo pushed a commit that referenced this pull request Mar 13, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
93591eb 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Mar 13, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
579935e 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Mar 13, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
7ac78be 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Mar 13, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
bb80f8b 
#10747)
nicolo-ribaudo pushed a commit that referenced this pull request Mar 22, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
ce9789d 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Mar 22, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
2fb51f6 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Mar 22, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
b42bf43 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Mar 22, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
90e0640 
#10747)
nicolo-ribaudo pushed a commit that referenced this pull request Apr 11, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
9fdbcf2 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Apr 11, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
20cdaab 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Apr 11, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
d3494cc 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Apr 11, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
fe42f30 
#10747)
@eps1lon eps1lon mentioned this pull request Apr 15, 2020
Closed
nicolo-ribaudo pushed a commit that referenced this pull request Apr 20, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
55783de 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Apr 20, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
38f8844 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Apr 20, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
79aad76 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Apr 20, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
af2f02d 
#10747)
nicolo-ribaudo pushed a commit that referenced this pull request Apr 21, 2020
@JLHwung @nicolo-ribaudo
Drop Node.js <10.13 support (#10747)
b8c5b49 
* chore: drop Node.js <10.9 support
* chore: update engines field
* chore: bump minimum node version to the first Dubrium LTS
* chore: bump other "engines"
* chore: tune testRegex
nicolo-ribaudo added a commit that referenced this pull request Apr 21, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
d8d9603 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
nicolo-ribaudo pushed a commit that referenced this pull request Apr 21, 2020
@JLHwung @nicolo-ribaudo
Bump dependencies (#10747)
e740d44 
slash -> ^3.0.0
chokidar -> ^3.3.1
globals -> ^12.3.0
find-cache-dir -> ^3.2.0
nicolo-ribaudo added a commit that referenced this pull request Apr 21, 2020
@nicolo-ribaudo
Use rollup-plugin-node-polyfills instead of node-globals+node-builtins (
3e59119 
#10747)
nicolo-ribaudo added a commit that referenced this pull request Apr 21, 2020
@JLHwung @nicolo-ribaudo
Remove polyfills and minNodeVersion for old Node.js (#10747)
8601a07 
* chore: remove fs.promises polyfill
* chore: replace make-dir by fs.mkdirSync
* refactor: remove node-environment-flags
* chore: remove unecessary minNodeVersion config

Co-authored-by: Nicolò Ribaudo <[email protected]>
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

+1 more reviewer

@coreyfarrell coreyfarrell coreyfarrell left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for node <8.9.0

5 participants

@JLHwung @kaicataldo @milesj @nicolo-ribaudo @coreyfarrell