Added jsescOptions to Numeric Literals#11028
Merged
nicolo-ribaudo merged 9 commits intobabel:masterfrom Mar 16, 2020
Merged
Conversation
1 task
Contributor
Author
|
Reffered the code from StringLiteral function for Numeric Literals. What can we use here instead of |
JLHwung
reviewed
Jan 17, 2020
JLHwung
reviewed
Jan 17, 2020
Contributor
Author
|
@JLHwung Made the changes. But it is affecting other tests. PTAL. |
JLHwung
reviewed
Jan 19, 2020
packages/babel-generator/test/fixtures/escapes/jsonEscape/output.js
Outdated
Show resolved
Hide resolved
JLHwung
reviewed
Jan 19, 2020
JLHwung
reviewed
Jan 19, 2020
JLHwung
reviewed
Jan 19, 2020
packages/babel-generator/test/fixtures/escapes/jsonEscape/options.json
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@JLHwung @nicolo-ribaudo PTAL now.
|
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I think that the logic should be something like this:
- Is
this.format.jsescOption.numbersis set,
i. Callthis.number(jsesc(node.value, this.format.jsescOption)) - Otherwise, fallback to our old unmodified logic.
If someone sets this.format.jsescOption.numbers, they are explicitly overwriting any other automatic logic used to format numbers (i.e. literal length when minified: true, or "use the raw value if it's possible").
Contributor
Author
|
@nicolo-ribaudo @JLHwung PTAL now. Have modified the conditions as mentioned above. |
Contributor
Author
|
@nicolo-ribaudo Made the changes. PTAL now. |
Contributor
Author
|
@nicolo-ribaudo Done. Please review. |
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.