feat(babel-parser): throw syntax error for } and > in JSX text#11046
Merged
nicolo-ribaudo merged 6 commits intobabel:next-8-devfrom Feb 4, 2020
bradzacher:11042-jsx-invalid-characters
Merged
feat(babel-parser): throw syntax error for } and > in JSX text#11046nicolo-ribaudo merged 6 commits intobabel:next-8-devfrom bradzacher:11042-jsx-invalid-characters
} and > in JSX text#11046nicolo-ribaudo merged 6 commits intobabel:next-8-devfrom
bradzacher:11042-jsx-invalid-characters
Conversation
kaicataldo
reviewed
Jan 23, 2020
jridgewell
reviewed
Jan 23, 2020
jridgewell
approved these changes
Jan 23, 2020
jridgewell
approved these changes
Jan 24, 2020
existentialism
approved these changes
Jan 24, 2020
kaicataldo
approved these changes
Jan 25, 2020
Member
|
Thanks! It will take a bit to merge this PR since we need to wait for Babel 8. |
kaicataldo
reviewed
Jan 27, 2020
Co-Authored-By: Kai Cataldo <[email protected]>
Member
|
I'm merging this to the |
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 4, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 6, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 6, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 9, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 13, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 20, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 23, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
JLHwung
pushed a commit
to JLHwung/babel
that referenced
this pull request
Feb 27, 2020
…#11046) * feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Feb 27, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Mar 3, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Mar 10, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Mar 11, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Mar 13, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
1 task
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Mar 22, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 11, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 20, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
arku
pushed a commit
to arku/babel
that referenced
this pull request
Apr 20, 2020
…#11046) * feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 21, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 21, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 22, 2020
* feat(babel-parser): throw syntax error for `}` and `>` in JSX text * feat: move validation earlier in parse * test: update flow test whitelist * feat: update message to include html entities * Update packages/babel-parser/src/plugins/jsx/index.js Co-Authored-By: Kai Cataldo <[email protected]> * fix: update snaps Co-authored-by: Kai Cataldo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the full context in #11042.
The JSX spec lists
}and>as invalid JSX text characters.Flow recently updated their parser so that it errors in this case.
This PR just does the same for Babel.
Looking for feedback, as I've never contributed to babel before.
Do we need explicit documentation for this change, or are the error messages "good enough"?