Enable allowNamespaces in transform-typescript by default#12765
Enable allowNamespaces in transform-typescript by default#12765nicolo-ribaudo merged 2 commits intobabel:mainfrom
transform-typescript by default#12765Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3ecbf22:
|
09002f2 to
4bf8ee8
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39897/ |
|
Is this actually a breaking change, or can we do it in a minor? |
|
Agreed that it can be shipped in a minor, since we are not removing this option. |
4bf8ee8 to
3ecbf22
Compare
transform-typescript by defaulttransform-typescript by default
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Imho we are ready to enable this by default now (in 7.13.0).
We introduced namespace support in 7.5.0 (July 2019) behind a flag because it was a big feature and we wanted people to test it as if it was a "beta".
After more than one year we got a few bug reports and we fixed them, and probably they are now as stable as any other Babel feature.
Unlike
useSpreadinpreset-reactwhich will be materialized in Babel 8, I don't think the TSNamespace feature is ready for that, but we can enable it by default in Babel 8 and gather more feedback.Note that
allowNamespaceshas been enabled by default inpreset-typescript(#12460), since it was extracted frombabel-8-dev.