Codestin Search App

JLHwung · 2021-03-10T16:06:33Z

Q	A
Fixed Issues?	Closes #12616
Patch: Bug Fix?
Major: Breaking Change?	Y, behind the `BABEL_8_BREAKING` flag
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link	babel/website#2765
Any Dependency Changes?
License	MIT

This PR is an alternative to #12616. When no browsers targets are set and ignoreBrowserslistConfig is false (default value), @babel/compilation-targets will return the browserlists query "defaults, not ie 11", thus @babel/preset-env will skip most transforms given their native support on these targets (as of Mar 2021):

npx browserslist --mobile-to-desktop "defaults, not ie 11"

and_chr 86
and_chr 85
and_ff 82
and_ff 81
and_qq 10.4
and_uc 12.12
android 86
android 85
baidu 7.12
chrome 86
chrome 85
chrome 84
edge 86
edge 85
firefox 82
firefox 81
firefox 78
ios_saf 14
ios_saf 13.4-13.7
ios_saf 13.3
ios_saf 12.2-12.4
kaios 2.5
op_mini all
op_mob 72
op_mob 71
opera 72
opera 71
safari 14
safari 13.1
samsung 12.0
samsung 11.1-11.2

Related plugins behaviour changes:

@babel/plugin-proposal-object-rest-spread will use Object.assign by default

@babel/helper-compilation-targets behaviour changes:

{ esmodules: "intersect" } without a target will become no op because defaults, not ie 11 have native esmodules support.

This PR includes commits from #12996.

JLHwung · 2021-03-10T16:07:58Z

packages/babel-preset-env/test/fixtures/corejs2/entry-all/output.mjs

-import "core-js/modules/es6.weak-set.js";
 import "core-js/modules/web.timers.js";
 import "core-js/modules/web.immediate.js";
 import "core-js/modules/web.dom.iterable.js";


Most core-js 2 polyfills are not used because defaults, not ie 11 already have native support.

babel-bot · 2021-03-10T16:09:04Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44286/

nicolo-ribaudo · 2021-03-10T16:09:51Z

cc @developit

codesandbox-ci · 2021-03-10T16:10:27Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9399e44:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

developit · 2021-03-10T17:00:02Z

@nicolo-ribaudo @JLHwung this will be fantastic with bugfixes defaulting to true.

nicolo-ribaudo · 2021-03-10T17:30:23Z

@developit Note that bugfixes: true almost doesn't change the behavior of defaults, not ie 11, since the all bugfixes we currently have except for bugfix/transform-tagged-template-caching target older browsers.

jridgewell

🎉 🎊 💯

developit · 2021-03-10T18:47:54Z

@nicolo-ribaudo ah sorry, I had misread - that makes sense given Safari 11 and prior are not included due to the % cutoff.

Just to clarify - op_mini all will still be excluded due to the data issues, right?

nicolo-ribaudo · 2021-03-10T18:50:25Z

Yes, we don't have data for op_mini all. If we'll ever have it, we'll make sure not to change the actual default behavior.

packages/babel-compat-data/data/native-modules.json

JLHwung · 2021-03-11T21:53:36Z

packages/babel-plugin-transform-runtime/test/fixtures/options.json

 {
-  "externalHelpers": false
+  "externalHelpers": false,
+  "targets": { "browsers": "ie 6, ios 4" }


Added ios 4 here because IE 5.5 has Array.map but not ios 4. Note that browserslist does not support IE 5.

JLHwung · 2021-03-11T21:56:31Z

...bel-plugin-transform-react-constant-elements/test/fixtures/integration/issue-10879/output.js

 };

-var buildTest = function buildTest(name) {
+const buildTest = name => {


We already have issue-10879-babel-7 for this test, so good to overwrite the test output.

nicolo-ribaudo · 2021-03-11T21:57:04Z

Can/should 32a2d00 be extracted to a separate smaller PR?

nicolo-ribaudo · 2021-03-11T22:02:18Z

packages/babel-plugin-proposal-decorators/test/fixtures/legacy-object-ordering/options.json

@@ -1,5 +1,5 @@
 {
-  "presets": ["env"],
+  "presets": [["env", { "targets": { "browsers": "ie 6" } }]],


Really a nit and only if you can do it with a regexp, but I find the top-level targets slightly more readable (less [ and {).

Do we still want to make this change? Guess it could be a separate PR?

We could track this in a separate PR but if we use top level targets, the output fixtures may need to be updated since plugins can be aware of that. This PR aims for minimizing fixtures update so we can move forward.

Ok yeah that sounds like a different issue entirely given that chance.

Really want to work on making these diffs easier to look through! Would be interesting to run our tests through a combination of retainLines/recast

hzoo

Probably one of the more helpful breaking changes that we do

default to es6+
makes users have to be aware of targets
we can do the ideas we were talking about with applying preset-modules/bugfixes to further syntax since current bugfixes wouldn't be applied like @nicolo-ribaudo mentioned?

nicolo-ribaudo

This is exciting 🎉

Fixes the issue caused by babel/babel#12989

JLHwung added the babel-8-dev → main label Mar 10, 2021

JLHwung commented Mar 10, 2021

View reviewed changes

JLHwung requested review from hzoo and nicolo-ribaudo March 10, 2021 16:08

jridgewell approved these changes Mar 10, 2021

View reviewed changes

JLHwung force-pushed the exclude-ie-in-default-targets branch from ab5f225 to 32a2d00 Compare March 11, 2021 21:31

JLHwung commented Mar 11, 2021

View reviewed changes

packages/babel-compat-data/data/native-modules.json Show resolved Hide resolved

JLHwung commented Mar 11, 2021

View reviewed changes

nicolo-ribaudo reviewed Mar 11, 2021

View reviewed changes

JLHwung mentioned this pull request Mar 12, 2021

Fix esmodule: "intersect" on iOS versions #12996

Merged

JLHwung force-pushed the exclude-ie-in-default-targets branch from 32a2d00 to d1b36e2 Compare March 12, 2021 19:37

JLHwung added 10 commits March 12, 2021 17:15

chore: update test options in class-properties

0c7ed49

chore: update test options

e524c80

chore: update Babel 8 test fixtures

2881a4a

async-generator-functions tests

6a25720

fix helper-compilation-targets test

9b7fdf6

fix transform-runtime tests

23018d1

fix flow tests

ecc54e6

fix object-rest-spread tests

e7dd0e8

fix babel-core tests

501d834

breaking: fallback targets to "defaults, not ie 11"

d738875

JLHwung added 3 commits March 12, 2021 17:15

chore: update entry-all test fixtures

cfc5193

chore: update test fixtures

c5b66bd

add Babel 7 tests for preset-env

9399e44

JLHwung force-pushed the exclude-ie-in-default-targets branch from d1b36e2 to 9399e44 Compare March 12, 2021 22:15

hzoo approved these changes Mar 23, 2021

View reviewed changes

nicolo-ribaudo approved these changes Mar 23, 2021

View reviewed changes

nicolo-ribaudo merged commit 6ee87ee into babel:main Mar 23, 2021

nicolo-ribaudo deleted the exclude-ie-in-default-targets branch March 23, 2021 19:17

JLHwung mentioned this pull request Mar 23, 2021

Only change browserslist defaults if no config file exists #9962

Closed

nicolo-ribaudo mentioned this pull request Mar 24, 2021

Fix e2e vue-cli Babel 8 tests #13050

Merged

JLHwung mentioned this pull request Mar 25, 2021

Babel 8 Release Plan #10746

Open

34 tasks

nicolo-ribaudo mentioned this pull request Apr 2, 2021

Try to resolve browserslist config when targets are not specified #10897

Closed

haoqunjiang added a commit to vuejs/vue-cli that referenced this pull request Apr 15, 2021

test: use explicit targets in babel tests

f782fa3

Fixes the issue caused by babel/babel#12989

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 23, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021

nicolo-ribaudo added babel 8 and removed babel-8-dev → main labels Aug 8, 2023

nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023

JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 9, 2023

Uh oh!

Conversation

JLHwung commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLHwung Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

babel-bot commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Mar 10, 2021

Uh oh!

codesandbox-ci bot commented Mar 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

developit commented Mar 10, 2021

Uh oh!

nicolo-ribaudo commented Mar 10, 2021

Uh oh!

jridgewell left a comment

Choose a reason for hiding this comment

Uh oh!

developit commented Mar 10, 2021

Uh oh!

nicolo-ribaudo commented Mar 10, 2021

Uh oh!

Uh oh!

JLHwung Mar 11, 2021

Choose a reason for hiding this comment

Uh oh!

JLHwung Mar 11, 2021

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo commented Mar 11, 2021

Uh oh!

nicolo-ribaudo Mar 11, 2021

Choose a reason for hiding this comment

Uh oh!

hzoo Mar 23, 2021

Choose a reason for hiding this comment

Uh oh!

JLHwung Mar 23, 2021

Choose a reason for hiding this comment

Uh oh!

hzoo Mar 23, 2021

Choose a reason for hiding this comment

Uh oh!

hzoo left a comment

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JLHwung commented Mar 10, 2021 •

edited

Loading

babel-bot commented Mar 10, 2021 •

edited

Loading

codesandbox-ci bot commented Mar 10, 2021 •

edited

Loading