[babel 8] Do not skip requeued paths#13291
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom May 11, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45971/ |
nicolo-ribaudo
approved these changes
May 10, 2021
Member
|
I added |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4692c79:
|
existentialism
approved these changes
May 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldSkipof a requeued pathBABEL_8_BREAKINGflagWhen a NodePath is skipped and then requeued, we should ignore the
shouldSkipotherwise it will not be visited. This is a breaking change because it breakstransform-block-scoping. The intention ofpath.skipin block-scoping is to avoid revisiting the transformed AST node. In this PR we check whether an AST node is visited before processing. In this waytransform-block-scopingcan work with both Babel 7 and Babel 8.