Codestin Search App

JLHwung · 2022-08-23T15:29:38Z

Q	A
Fixed Issues?	Fixes #14496
Patch: Bug Fix?	ESLint rule `@babel/semi` conflicts with ESLint 8.0.0 when reporting class properties trailing commas
Major: Breaking Change?	Yes
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?	`eslint-scope` is bumped to 7.1.1 and `eslint-visitor-keys` to 3.3.0
License	MIT

Bumped eslint-scope and eslint-visitor-keys. Because they drop Node.js 10 support, the update is behind the BABEL_8_BREAKING flag.

This PR also bumps eslint dev dependencies to ESLint 8 and fixes compatibility issues of the following rules:

semi
no-invalid-this

Because ESLint 8 officially supported class properties / private methods. These rules become no-op when using with ESLint 8.

In this PR we also introduce a new test workflow eslint7-test where we downgrade eslint to 7 and run the eslint related tests. The test is refactored so that we can test eslint parser/plugins against either ESLint 7 or ESLint 8, but not both. Compared to the current approach, the new approach

avoid the test interference when one test worker is testing eslint plugins with ESLint 8 and another worker is testing @babel/eslint-parser with ESLINT_VERSION_FOR_BABEL = 7
test other @babel/eslint-* with both ESLint 7 and ESLint 8
simplify the build process by removing a customized Babel plugin

Hopefully we can remove this workflow when we decide to drop ESLint 7 support in the future.

I wish we could match the Node.js release frequency, otherwise when our deps drop unmaintained Node.js versions support, we have to either 1) pin older versions because we can't drop EOL node versions in minors, or 2) fork the legacy dep and offer runtime switch like we did for chokidar@2.

babel-bot · 2022-08-23T15:32:47Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52920/

JLHwung · 2022-08-23T15:38:59Z

The CI error is related: It seems like a package manager issue, I am investigating.

JLHwung · 2022-08-24T14:56:00Z

OK. CI is failing because the sub module import eslint/lib/definitions is not proxied in the yarn-plugin-conditions wrapper package. @nicolo-ribaudo I think supporting undeclared sub imports will be an overkill for that plugin, should we fork eslint-scope 5.1?

nicolo-ribaudo · 2022-09-05T14:57:49Z

@JLHwung Instead of forking I just created a small proxy package: https://github.com/nicolo-ribaudo/eslint-scope-5-internals

JLHwung · 2022-09-06T15:02:55Z

The current E2E test is failing because ESLint v8 supports class properties / private methods, but babel-eslint-plugin is not aware of that and thus reports essentially duplicate errors.

We can detect ESLint v8 and make the following rules as no-op:

semi
no-invalid-this
object-curly-spacing

I don't think we should remove rules, in case in the future new syntaxes require extension again.

will rereview

JLHwung · 2022-09-09T19:35:45Z

-    if (eslintVersion !== 8) {
+    if (isESLint7) {
+      if (process.env.IS_PUBLISH) {
+        console.warn("Skipping ESLint 7 test because using a release build.");


Now the published build will test against ESLint 8 only.

JLHwung · 2022-09-09T19:36:17Z

+      const espreeAST = espree.parse(code, {
        ...espreeOptions,
-        ecmaVersion: 2022,
+        ecmaVersion: "latest",


ESLint 8 also supports ES2023 so I put "latest" here.

nicolo-ribaudo

Thank you!

JLHwung · 2022-09-13T15:39:41Z

Rebased on latest main.

nicolo-ribaudo · 2022-09-13T16:19:28Z

I removed the label so that it doesn't go in the changelog (because this pr is for Babel 8)

JLHwung · 2022-09-13T16:26:08Z

Well the bug fix commit 37ef28c will be shipped to Babel 7 anyway.

JLHwung added PR: Dependency ⬆️ area: eslint labels Aug 23, 2022

existentialism previously approved these changes Aug 23, 2022

View reviewed changes

nicolo-ribaudo force-pushed the bump-eslint-parser-deps branch from 9a02e1c to ec9382c Compare September 5, 2022 14:56

nicolo-ribaudo changed the title ~~Bump eslint parser deps~~ [babel 8] Bump eslint parser deps Sep 5, 2022

nicolo-ribaudo added the babel-8-dev → main label Sep 5, 2022

JLHwung marked this pull request as draft September 7, 2022 19:02

JLHwung force-pushed the bump-eslint-parser-deps branch 2 times, most recently from 295dfa3 to 0df1b61 Compare September 9, 2022 19:00

JLHwung marked this pull request as ready for review September 9, 2022 19:31

JLHwung added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Sep 9, 2022

JLHwung commented Sep 9, 2022

View reviewed changes

nicolo-ribaudo approved these changes Sep 13, 2022

View reviewed changes

liuxingbaoyu approved these changes Sep 13, 2022

View reviewed changes

JLHwung force-pushed the bump-eslint-parser-deps branch from 13507a9 to a730988 Compare September 13, 2022 15:38

JLHwung and others added 8 commits September 13, 2022 11:38

breaking: bump eslint-parser deps

72bfbd2

bump eslint dev deps

7d45a2c

Use @nicolo-ribaudo/eslint-scope-5-internals

66ff8ce

Fix tests relying on ESLint 7 API

d5a0711

drop Node.js v10 test

ec2b311

swap eslint with eslint-8

4e69fb4

chore: mark ecmaVersion as latest

7e75b6a

add parseForESLint7

53ad72e

JLHwung added 6 commits September 13, 2022 11:39

fix: forward the original rule in ESLint 8

37ef28c

test: remove parseForESLint7

4b05d1d

remove dynamicESLintVersionCheck plugin

56ff629

Add eslint-7 test workflow

b079af2

cleanup parseAndAssertSame interface

d08aeed

remove unreachable warning

0bdf610

JLHwung force-pushed the bump-eslint-parser-deps branch from a730988 to 0bdf610 Compare September 13, 2022 15:39

nicolo-ribaudo approved these changes Sep 13, 2022

View reviewed changes

nicolo-ribaudo merged commit 091ac3d into babel:main Sep 13, 2022

nicolo-ribaudo deleted the bump-eslint-parser-deps branch September 13, 2022 16:18

nicolo-ribaudo removed the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Sep 13, 2022

nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Sep 14, 2022

nicolo-ribaudo changed the title ~~[babel 8] Bump eslint parser deps~~ Use the built-in class fields and private methods rules in ESLint 8 Sep 14, 2022

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 14, 2022

github-actions Bot locked as resolved and limited conversation to collaborators Dec 14, 2022

nicolo-ribaudo added babel 8 and removed babel-8-dev → main labels Aug 8, 2023

JLHwung added the PR: Internal (next major) 🏠 A type of pull request used for our changelog categories for next major release label Aug 9, 2023

JLHwung added this to the v8.0.0 milestone Aug 9, 2023

JLHwung removed the babel 8 label Aug 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use the built-in class fields and private methods rules in ESLint 8#14872

Use the built-in class fields and private methods rules in ESLint 8#14872
nicolo-ribaudo merged 14 commits into
babel:mainfrom
JLHwung:bump-eslint-parser-deps

JLHwung commented Aug 23, 2022 •

edited

Loading

Uh oh!

babel-bot commented Aug 23, 2022 •

edited

Loading

Uh oh!

JLHwung commented Aug 23, 2022

Uh oh!

JLHwung commented Aug 24, 2022

Uh oh!

nicolo-ribaudo commented Sep 5, 2022

Uh oh!

JLHwung commented Sep 6, 2022

Uh oh!

JLHwung Sep 9, 2022

Uh oh!

JLHwung Sep 9, 2022

Uh oh!

nicolo-ribaudo left a comment

Uh oh!

JLHwung commented Sep 13, 2022

Uh oh!

nicolo-ribaudo commented Sep 13, 2022

Uh oh!

JLHwung commented Sep 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

JLHwung commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JLHwung commented Aug 23, 2022

Uh oh!

JLHwung commented Aug 24, 2022

Uh oh!

nicolo-ribaudo commented Sep 5, 2022

Uh oh!

JLHwung commented Sep 6, 2022

Uh oh!

JLHwung Sep 9, 2022

Choose a reason for hiding this comment

Uh oh!

JLHwung Sep 9, 2022

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

JLHwung commented Sep 13, 2022

Uh oh!

nicolo-ribaudo commented Sep 13, 2022

Uh oh!

JLHwung commented Sep 13, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JLHwung commented Aug 23, 2022 •

edited

Loading

babel-bot commented Aug 23, 2022 •

edited

Loading