[babel 8] Other Babel 8 misc changes#15576
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54333/ |
JLHwung
reviewed
Apr 19, 2023
Contributor
There was a problem hiding this comment.
So the breaking changes of this PR are:
- Stop supporting presets/plugins with named exports, essentially reverting #4620
- Per package renames, the
includesandexcludespreset-envoptions will now only respect new plugin names
Other changes like removing the compat code for legacy helpers are not actually breaking. Did I miss any breaking changes?
Member
Author
|
@JLHwung That's correct 👍 All the other changes are just internal changes. |
JLHwung
approved these changes
Apr 24, 2023
Comment on lines
11
to
21
| function escape(code: number) { | ||
| let str = code.toString(16); | ||
| // Sigh, node 6 doesn't have padStart | ||
| // TODO: Remove in Babel 8, when we drop node 6. | ||
| while (str.length < 4) str = "0" + str; | ||
| return "\\u" + str; | ||
| if (process.env.BABEL_8_BREAKING) { | ||
| return "\\u" + code.toString(16); | ||
| } else { | ||
| let str = code.toString(16); | ||
| // Sigh, node 6 doesn't have padStart | ||
| // TODO: Remove in Babel 8, when we drop node 6. | ||
| while (str.length < 4) str = "0" + str; | ||
| return "\\u" + str; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think I've made a mistake, but it seems the tests don't cover it.
0fbe4b8 to
6ff7197
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are almost all the remaining
TODO(Babel 8)comments :)What remains to do (in other PRs):
2023-05#15570noNewArrowassumption to default tofalse(I now think we shouldn't if they are still compiled by our default targets)babel/packages/babel-traverse/src/path/introspection.ts
Line 337 in fe42965