Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[babel 8] Bump eslint-parser/plugin eslint requirements#15763

Merged
nicolo-ribaudo merged 4 commits into
babel:mainfrom
JLHwung:bump-babel-eslint-eslint-deps
Jul 18, 2023
Merged

[babel 8] Bump eslint-parser/plugin eslint requirements#15763
nicolo-ribaudo merged 4 commits into
babel:mainfrom
JLHwung:bump-babel-eslint-eslint-deps

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Jul 7, 2023

Q                       A
Fixed Issues? Closes #15563
Patch: Bug Fix?
Major: Breaking Change? Yes, under BABEL_8_BREAKING flag
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2765
Any Dependency Changes?
License MIT

In this PR we bumped the ESLint requirements of @babel/eslint-parser 8 and @babel/eslint-plugin 8, because Babel parser 8, when enabled with estree plugin, will not return the Babel style class features AST that an ESLint 7 plugin is expecting.

In this PR we also change the peerDependencies specification from >= to the current equivalent ^ notations. It will not break any current users, but will serve as a guard when we need certain updates to support any major versions of @babel/core or eslint. We can always broaden the support matrix in the future.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jul 7, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54873/

@JLHwung JLHwung mentioned this pull request Jul 7, 2023
11 tasks
@JLHwung JLHwung force-pushed the bump-babel-eslint-eslint-deps branch from 7551761 to 9a1bc36 Compare July 14, 2023 22:01
@nicolo-ribaudo nicolo-ribaudo changed the title Bump eslint-parser/plugin eslint requirements [babel 8] Bump eslint-parser/plugin eslint requirements Jul 18, 2023
@nicolo-ribaudo nicolo-ribaudo merged commit a21be92 into babel:main Jul 18, 2023
@nicolo-ribaudo nicolo-ribaudo deleted the bump-babel-eslint-eslint-deps branch July 18, 2023 14:51
@nicolo-ribaudo nicolo-ribaudo added this to the v8.0.0 milestone Aug 8, 2023
@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Aug 9, 2023
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 9, 2023
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump ESLint requirements in @babel/eslint-{parser,plugin} 8

3 participants