[babel 8] Numeric literals must be finite and non-negative#15802
Merged
nicolo-ribaudo merged 5 commits intoJul 21, 2023
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/54933/ |
JLHwung
approved these changes
Jul 20, 2023
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Can you prepare a docs PR?
liuxingbaoyu
approved these changes
Jul 20, 2023
Contributor
|
As for docs PR, I was meant for a migration note pushed to babel/website#2765. I can update that PR. |
Member
Author
|
Oh ok, thanks! I'll push to your branch. |
JLHwung
added a commit
to JLHwung/babel-website
that referenced
this pull request
Jul 21, 2023
Contributor
Updated, please take a look. Thanks! That PR is probably good to merge because the V8 migration docs will only show up on the Babel 8 website. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to start warning in Babel 7, but we first need to fix regenerator to not pass negative numbers to
t.numericLiteral.