Require exact Babel 8 version in assertVersion#15955
Merged
nicolo-ribaudo merged 4 commits intoOct 13, 2023
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55506/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55433/ |
Member
Author
|
Ugh |
0f3c989 to
a2916a1
Compare
Member
Author
|
I'll eventually work on a PR to properly support |
JLHwung
reviewed
Sep 11, 2023
| minSupportedCoreVersion += " || >=8.0.0-0"; | ||
| } | ||
| const minSupportedCoreVersion = process.env.BABEL_8_BREAKING | ||
| ? PACKAGE_JSON.version |
Contributor
There was a problem hiding this comment.
Suggested change
| ? PACKAGE_JSON.version | |
| ? ">=8.0.0-0" |
otherwise we will keep bumping Babel 8 requirements in every babel eslint parser 8 releases.
Member
Author
There was a problem hiding this comment.
I think during the prerelease period we'd want everything to be exactly at the same version, and then we relax it to ^8.0.0 once stable.
a2916a1 to
057551d
Compare
Member
Author
|
The first commit is from #15961. |
057551d to
1169375
Compare
3f6b265 to
71818a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Once we release 8.0.0 stable, we'll have to use
process.env.BABEL_8_BREAKING ? "^8.0.0" : "..."instead.