fix: preset-env throws exception for export * as x#16181
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56104/ |
8497675 to
05afe06
Compare
|
Because of its existence, it did not cause a more serious regression. babel/packages/babel-preset-env/src/index.ts Lines 407 to 418 in 3284897 |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
The old error makes sense when one feature was standard and one a proposal. Now nobody even knows that export * as was not introduced together with ESM.
|
This would be not consistent with how we treat dynamic I think the expected behaviour should be: let |
2b0245e to
aa95f16
Compare
|
actions/download-artifact#249 |
e5cddc4 to
16ee5b5
Compare
|
I'd like to release a patch once this is merged. |
|
Hi @liuxingbaoyu @JLHwung @nicolo-ribaudo After the babel related dependencies in our project were upgraded from If I want the page to work fine, I need to use one of two following ways:
What I'm curious about now is why 7.23.7 version doesn't need to add/update configurations, but 7.23.8 version needs to change these configurations. I feel that it is related to the three latest PR changes (#16181 #16201 #16199), but I can't find the specific point. Can you help me check it out? will appreciate it. |
|
Only this PR is relevant between 7.23.7 and 7.23.8, but I don't know how it breaks your build. |
|
Thanks for your quick reply, I can't reproduce it on the practice demo, but I will try it on serval times, if reproduced successfully, I will provide it. |
Uh oh!
There was an error while loading. Please reload this page.