Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Babel 8] Split typeParameter of TSMappedType#16733

Merged
nicolo-ribaudo merged 4 commits into
babel:mainfrom
liuxingbaoyu:TSMappedType
Aug 23, 2024
Merged

[Babel 8] Split typeParameter of TSMappedType#16733
nicolo-ribaudo merged 4 commits into
babel:mainfrom
liuxingbaoyu:TSMappedType

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented Aug 10, 2024 •
edited
Loading

Q                       A
Fixed Issues? #16679
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2939
Any Dependency Changes?
License MIT

@liuxingbaoyu liuxingbaoyu added pkg: generator pkg: parser pkg: types PR: Needs Docs PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release area: typescript labels Aug 10, 2024
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Aug 10, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57717

@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release labels Aug 12, 2024
@liuxingbaoyu liuxingbaoyu force-pushed the TSMappedType branch 2 times, most recently from cf58333 to 18496bc Compare August 12, 2024 22:05
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshuaKGoldberg
Copy link
Copy Markdown
Contributor

JoshuaKGoldberg commented Aug 13, 2024

Back-linking for reference: typescript-eslint/typescript-eslint#7065

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Aug 13, 2024
Closed
11 tasks
@liuxingbaoyu
Copy link
Copy Markdown
Member Author

liuxingbaoyu commented Aug 15, 2024

The PR failure seems a bit difficult to fix unless we also land it in Babel 7.

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Aug 16, 2024

Can we skip those prettier tests for now?

@liuxingbaoyu liuxingbaoyu force-pushed the TSMappedType branch 2 times, most recently from 53d6839 to 3038ec1 Compare August 16, 2024 08:54
@liuxingbaoyu liuxingbaoyu mentioned this pull request Aug 22, 2024
Merged
@nicolo-ribaudo nicolo-ribaudo merged commit 15328eb into babel:main Aug 23, 2024
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 23, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

+1 more reviewer

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator pkg: parser pkg: types PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liuxingbaoyu @babel-bot @JoshuaKGoldberg @nicolo-ribaudo @JLHwung