Codestin Search App

liuxingbaoyu · 2024-12-04T18:12:58Z

Q	A
Fixed Issues?	Fixes #16999
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

#16923 caused the regression, but the source of the problem was not there.
The source of the problem was that transform-modules-amd corrupted the container of the paths in the traversal queue.

babel/packages/babel-plugin-transform-modules-amd/src/index.ts

Lines 32 to 45 in 844901e

    
           const { body, directives } = path.node; 
        
           path.node.directives = []; 
        
           path.node.body = []; 
        
           const amdFactoryCall = path 
        
             .pushContainer("body", wrapper)[0] 
        
             .get("expression") as NodePath<t.CallExpression>; 
        
           const amdFactoryCallArgs = amdFactoryCall.get("arguments"); 
        
           const amdFactory = ( 
        
             amdFactoryCallArgs[ 
        
               amdFactoryCallArgs.length - 1 
        
             ] as NodePath<t.FunctionExpression> 
        
           ).get("body"); 
        
           amdFactory.pushContainer("directives", directives); 
        
           amdFactory.pushContainer("body", body);

changed Program.body.

babel/packages/babel-traverse/src/context.ts

Line 128 in 844901e

resync.call(path);

causes nodes added to Program.body via pushContainer to have wrong container and key in subsequent traversals.
Then the crash happens when we use the wrong container.

Maybe we also add a temporary fix to @babel/traverse in Babel 7? I'm not sure how many people will accidentally use the new traverse with the old transform-modules-amd.

babel-bot · 2024-12-04T18:15:00Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58416

liuxingbaoyu · 2024-12-04T18:56:51Z

Maybe we also add a temporary fix to @babel/traverse in Babel 7? I'm not sure how many people will accidentally use the new traverse with the old transform-modules-amd.

Yes, we should, because it seems that the act of arbitrarily moving nodes to children will cause this problem.
The CI issue at #16965 is also related to this.

nicolo-ribaudo · 2024-12-04T19:03:38Z

How would you feel about reverting #16923, and re-landing it (together with this PR) for babel 8?

JLHwung · 2024-12-04T19:23:43Z

+      Identifier(path) {
+        if (!bool) {
+          bool = true;
+          path.parentPath.parentPath.pushContainer("body", t.functionDeclaration(t.identifier("fn"), [t.identifier("x")], t.blockStatement([])));


Can you add some assertions to this test so that it will fail without the changes in the amd transform? Currently this test is already passing given only the babel-traverse changes.

JLHwung · 2024-12-04T19:25:52Z

Since #16998 is introducing a currently breaking e2e test, could you rebase this PR onto #16998 so that we can be confident that there is no other breaking changes for ember?

liuxingbaoyu · 2024-12-05T01:47:04Z

How would you feel about reverting #16923, and re-landing it (together with this PR) for babel 8?

I'm slightly inclined to try this before reverting, because I want to accumulate significant performance changes before v7.27.0. :)

liuxingbaoyu · 2024-12-05T01:51:01Z

Or we revert it and only count the performance changes for Babel 8, since #16965 seems a bit riskier than this.🤦‍♂️

nicolo-ribaudo · 2024-12-05T10:57:13Z

The reason I prefer reverting is that it's very common for people to be on an older version of some package, and in this case the fix in transform-modules-amd feels very hacky. It's @babel/traverse that should be responsible of keeping the correct AST metadata (maybe in pushContainer?), and not something that plugins should manually patch. I'm thus worried that here we found one breakage, but it could potentially break any other plugin that moves nodes around.

As an alternative, I would prefer a fix that only involves @babel/traverse.

liuxingbaoyu · 2024-12-05T11:02:49Z

As an alternative, I would prefer a fix that only involves @babel/traverse.

Yes, I submitted the fix for only traverse in the second commit. :)

305d3be (#17001)

But now there are two issues that I need to test whether they have been fixed by the two PRs. So revert may also be a good choice.
#17004
istio/istio.io#16053

liuxingbaoyu · 2024-12-13T13:54:14Z

I investigated the bug with babel-minify in istio/istio.io#16053 and luckily it was fixed by this patch as well.
The reason was https://github.com/babel/minify/blob/8f9c7c0a32103653bd6793d0ce44730f937e1ddf/packages/babel-plugin-minify-mangle-names/src/index.js#L77-L80 which cleared the cache but still held programPath.
Before this patch we looked up the cache and created a new programPath, now we still use the old programPath.

liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Dec 4, 2024

JLHwung reviewed Dec 4, 2024

View reviewed changes

ci: add ember e2e test

bb55483

liuxingbaoyu added 3 commits December 5, 2024 09:39

fix

5b7605c

fix

305d3be

review

d7685a5

liuxingbaoyu force-pushed the fix-amd-scope branch from de713e7 to d7685a5 Compare December 5, 2024 01:39

liuxingbaoyu added 2 commits December 5, 2024 09:57

test

c1efc9c

e2e

396f396

JhayceFrancis approved these changes Dec 5, 2024

View reviewed changes

JLHwung mentioned this pull request Dec 5, 2024

ci: add ember e2e test #16998

Merged

liuxingbaoyu closed this Jan 2, 2025

JhayceFrancis approved these changes Jan 9, 2025

View reviewed changes

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 11, 2025

github-actions Bot locked as resolved and limited conversation to collaborators Apr 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Regression of new `traverse` with `transform-modules-amd`#17001

fix: Regression of new `traverse` with `transform-modules-amd`#17001
liuxingbaoyu wants to merge 6 commits into
babel:mainfrom
liuxingbaoyu:fix-amd-scope

liuxingbaoyu commented Dec 4, 2024

Uh oh!

babel-bot commented Dec 4, 2024 •

edited

Loading

Uh oh!

liuxingbaoyu commented Dec 4, 2024 •

edited

Loading

Uh oh!

nicolo-ribaudo commented Dec 4, 2024

Uh oh!

JLHwung Dec 4, 2024 •

edited

Loading

Uh oh!

JLHwung commented Dec 4, 2024

Uh oh!

liuxingbaoyu commented Dec 5, 2024

Uh oh!

liuxingbaoyu commented Dec 5, 2024

Uh oh!

nicolo-ribaudo commented Dec 5, 2024 •

edited

Loading

Uh oh!

liuxingbaoyu commented Dec 5, 2024

Uh oh!

liuxingbaoyu commented Dec 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	const { body, directives } = path.node;
	path.node.directives = [];
	path.node.body = [];
	const amdFactoryCall = path
	.pushContainer("body", wrapper)[0]
	.get("expression") as NodePath<t.CallExpression>;
	const amdFactoryCallArgs = amdFactoryCall.get("arguments");
	const amdFactory = (
	amdFactoryCallArgs[
	amdFactoryCallArgs.length - 1
	] as NodePath<t.FunctionExpression>
	).get("body");
	amdFactory.pushContainer("directives", directives);
	amdFactory.pushContainer("body", body);

Uh oh!

Conversation

liuxingbaoyu commented Dec 4, 2024

Uh oh!

babel-bot commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxingbaoyu commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Dec 4, 2024

Uh oh!

JLHwung Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JLHwung commented Dec 4, 2024

Uh oh!

liuxingbaoyu commented Dec 5, 2024

Uh oh!

liuxingbaoyu commented Dec 5, 2024

Uh oh!

nicolo-ribaudo commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liuxingbaoyu commented Dec 5, 2024

Uh oh!

liuxingbaoyu commented Dec 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

babel-bot commented Dec 4, 2024 •

edited

Loading

liuxingbaoyu commented Dec 4, 2024 •

edited

Loading

JLHwung Dec 4, 2024 •

edited

Loading

nicolo-ribaudo commented Dec 5, 2024 •

edited

Loading