fix(traverse): provide a hub when traversing a File or Program and no parentPath is given#17708
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60722 |
|
commit: |
nicolo-ribaudo
approved these changes
Jan 28, 2026
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
Summary: [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue. This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Differential Revision: D92710292
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
Summary: [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue in [v7.29.0](https://github.com/babel/babel/releases/tag/v7.29.0). This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Changelog: Internal Reviewed By: robhogan Differential Revision: D92710292
vzaidman
added a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
Summary: [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue in [v7.29.0](https://github.com/babel/babel/releases/tag/v7.29.0). This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Changelog: Internal Reviewed By: robhogan Differential Revision: D92710292
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
…1650) Summary: [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue in [v7.29.0](https://github.com/babel/babel/releases/tag/v7.29.0). This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Changelog: Internal Reviewed By: robhogan Differential Revision: D92710292
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
…1650) Summary: [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue in [v7.29.0](https://github.com/babel/babel/releases/tag/v7.29.0). This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Changelog: Internal Reviewed By: robhogan Differential Revision: D92710292
facebook-github-bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
…1650) Summary: [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue in [v7.29.0](https://github.com/babel/babel/releases/tag/v7.29.0). This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Changelog: Internal Reviewed By: robhogan Differential Revision: D92710292
meta-codesync Bot
pushed a commit
to facebook/metro
that referenced
this pull request
Feb 9, 2026
…1650) Summary: Pull Request resolved: #1650 [#17708](babel/babel#17708) fixes the longstanding `babel/traverse` pollution issue in [v7.29.0](https://github.com/babel/babel/releases/tag/v7.29.0). This diff opts-out of the workaround if the version of traverse is above the version where it was fixed. Changelog: Internal Reviewed By: robhogan Differential Revision: D92710292 fbshipit-source-id: 6b202c001cdf5d2ec02c81c3e9f280752d83c998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed: :)
Originally posted by @nicolo-ribaudo in #17672 (comment)