[Babel 8] Extract babel-build-external-helpers#17746
Conversation
| @@ -0,0 +1,3 @@ | |||
| import { runParallel } from "../helpers/runner.js"; | |||
|
|
|||
| runParallel(parseInt(import.meta.url.split("/").pop().split(".")[0]), 2); | |||
There was a problem hiding this comment.
We chose 2 test runners as there aren't many tests in the external-helpers-cli.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60774 |
28862d9 to
d239104
Compare
|
commit: |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Can we call it @babel/generate-external-helpers, so that people can run it as npx @babel/generate-external-helpers -l foo,bar, which reads nice?
| program.option( | ||
| "-w, --whitelist <whitelist>", | ||
| "Deprecated: use --allowlist instead", | ||
| collect, |
There was a problem hiding this comment.
Let's just throw instead of only showing a deprecation message. People are migrating to a new package anyway, they can change the option name while doing it.
The underlying |
7079a6a to
f90afd8
Compare
|
Could you rebase on top of |
f90afd8 to
d5e8e3e
Compare
|
Perfect, it detects the new package. I'd say that in cases like this we run the command to create the package right before merging the PR. |
|
Package created, the local script worked perfectly :) |
|
For some reason it wasn't enough to re-run the "ensure npm packages exist" job to make it pass, I had to rerun everything. |
In this PR we extract
build-external-helpersfrombabel-cli.We also add an
allowlistoption and deprecate thewhitelistoption. The newexternal-helpers-cliwill also check the required option values for--allowlistand--output-type.