Open
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61048 |
nicolo-ribaudo
commented
Feb 20, 2026
Comment on lines
+1
to
+2
| // TODO: Not supported yet | ||
| let promise = import("./x", { with: { type: "bytes" } }); |
Member
Author
There was a problem hiding this comment.
We also do not support this for JSON yet.
nicolo-ribaudo
commented
Feb 20, 2026
Comment on lines
+1
to
+2
| const json = await fetch(import.meta.resolve("./x")).then(r => r.json()); | ||
| const bytes = await fetch(import.meta.resolve("./x")).then(r => r.bytes()).then(_immutableUint8Array); |
Member
Author
There was a problem hiding this comment.
The same currently happens with WASM+JSON imports. I'll look into making them happen in parallel, like JSON+JSON.
10b9a9c to
72b9365
Compare
|
commit: |
72b9365 to
d52021e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2First commit is from #17816.
This PR adds support for the https://github.com/tc39/proposal-import-bytes proposal. I'm calling the plugin
proposal-bytes-modules, for consistency withtransform-json-modules.