Test Node.js 26 on CI#17989
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61567 |
JLHwung
previously approved these changes
May 8, 2026
|
commit: |
Member
Author
|
The windows failure is a test throwing: |
Member
Author
|
Oh well, it seems like the chokidar + Node.js 26 + windows combination is broken: libuv/libuv#5010 (comment) Let's skip this test for now? @liuxingbaoyu Can you reproduce it locally, or is it only on GH actions? |
Member
|
I am unable to reproduce this issue locally. |
Member
|
libuv/libuv#5010 (comment) |
liuxingbaoyu
approved these changes
May 16, 2026
JLHwung
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Depends on #17988