chore: use bundled dts for register and eslint-*#17993
Merged
Merged
Conversation
JLHwung
commented
May 11, 2026
| "./overlapping-plugins": "./data/overlapping-plugins.json", | ||
| "./plugin-bugfixes": "./data/plugin-bugfixes.json" | ||
| "./plugin-bugfixes": "./data/plugin-bugfixes.json", | ||
| "./package.json": "./package.json" |
Contributor
Author
There was a problem hiding this comment.
This is caught by the new rule: Enforce ./package.json export for all public packages.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61582 |
|
commit: |
nicolo-ribaudo
approved these changes
May 12, 2026
liuxingbaoyu
approved these changes
May 17, 2026
Member
liuxingbaoyu
left a comment
There was a problem hiding this comment.
I manually checked the generated type files, and they don't look as good as before. Let's align them.
Such as
declare const meta: {
name: string;
version: string;
};
declare function parse(code: string, options?: {}): any;
declare function parseForESLint(code: string, options?: {}): {
ast: any;
scopeManager: any;
visitorKeys: Record<string, string[]>;
};
declare const _default: {
meta: {
name: string;
version: string;
};
parse: typeof parse;
parseForESLint: typeof parseForESLint;
};
export { _default as default, meta, parse, parseForESLint };
Contributor
Author
Good catch, here is the updated generated typings: import { Linter, AST, ESLint } from 'eslint';
declare const meta: ESLint.ObjectMetaProperties["meta"];
declare function parse(code: string, options?: Linter.ParserOptions): AST.Program;
declare function parseForESLint(code: string, options?: Linter.ParserOptions): Linter.ESLintParseResult;
declare const _default: {
meta: {
name?: string | undefined;
version?: string | undefined;
};
parse: typeof parse;
parseForESLint: typeof parseForESLint;
};
export { _default as default, meta, parse, parseForESLint };Does it look good to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we use bundled dts for
@babel/registerand@babel/eslint-*. We also cleaned up the yarn constraints config.