Remove functions present only for backwards-compatibility#6993
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6129/ |
|
Reference: #6989 |
|
@xtuc There are also JSX builders, so it is. |
|
@nicolo-ribaudo good point, i've been flying across that PR and haven't seen them. This is a breaking change, I don't think we can land this in Babel 7. What about warning and removing it in Babel 8? |
|
Well, in Babel 7 we already made different breaking changes in pre releases |
|
We can definetely land a breaking change in the beta, just need to add a changelog entry and add this to the list of things to codemod |
|
I'm for making this change in 8.x. If it was just TS it'd be fine, but since it's essentially a meaningless breaking change for JSX, I'd rather leave it, encourage people to transition during 7.x's lifetime, and remove it in 8.x. If we want to special-case this PR to just drop it for TS that'd be fine with me. |
|
Alright, I'm ok with that |
|
Moved to #11095 |
Noticed in DefinitelyTyped/DefinitelyTyped#21972 that there were functions like
tSInterfaceDeclarationbeing generated, whiletsInterfaceDeclarationlooks better. It looks like this was done only for backwards-compatibility, but it should be fine to remove this for babel 7, right?