Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove functions present only for backwards-compatibility#6993

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

Remove functions present only for backwards-compatibility#6993
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 7, 2017

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Tests pass
Documentation PR
Any Dependency Changes? No
License MIT

Noticed in DefinitelyTyped/DefinitelyTyped#21972 that there were functions like tSInterfaceDeclaration being generated, while tsInterfaceDeclaration looks better. It looks like this was done only for backwards-compatibility, but it should be fine to remove this for babel 7, right?

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 7, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6129/

@nicolo-ribaudo
Copy link
Member

Reference: #6989

@xtuc xtuc added area: typescript PR: Polish 💅 A type of pull request used for our changelog categories labels Dec 12, 2017
Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Andy-MS.

I'm not sure that's a breaking change. TypeScript has been introduced recently and the exports were only available in beta/alpha.

I'm 👍 with removing them.

@nicolo-ribaudo
Copy link
Member

@xtuc There are also JSX builders, so it is.

@xtuc
Copy link
Member

xtuc commented Dec 12, 2017

@nicolo-ribaudo good point, i've been flying across that PR and haven't seen them.

This is a breaking change, I don't think we can land this in Babel 7. What about warning and removing it in Babel 8?

@nicolo-ribaudo
Copy link
Member

Well, in Babel 7 we already made different breaking changes in pre releases

@hzoo
Copy link
Member

hzoo commented Dec 13, 2017

We can definetely land a breaking change in the beta, just need to add a changelog entry and add this to the list of things to codemod

@xtuc
Copy link
Member

xtuc commented Dec 13, 2017

@nicolo-ribaudo nicolo-ribaudo added area: jsx PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release labels Dec 19, 2017
@Jessidhia Jessidhia added this to the Babel 7 RC milestone Apr 18, 2018
@loganfsmyth
Copy link
Member

I'm for making this change in 8.x. If it was just TS it'd be fine, but since it's essentially a meaningless breaking change for JSX, I'd rather leave it, encourage people to transition during 7.x's lifetime, and remove it in 8.x.

If we want to special-case this PR to just drop it for TS that'd be fine with me.

@hzoo
Copy link
Member

hzoo commented Apr 23, 2018

Alright, I'm ok with that

@nicolo-ribaudo
Copy link
Member

Moved to #11095

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: jsx area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Polish 💅 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants