Codestin Search App

mAAdhaTTah · 2018-07-08T20:06:49Z

Q	A
Fixed Issues?	Related to babel/proposals#29
Patch: Bug Fix?	No
Major: Breaking Change?	No
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link	N/A
Any Dependency Changes?
License	MIT

Most of this work was implemented by the illustrious @js-choi, which some adjustments and refreshments from myself to use the new plugin options API. He's been fairly busy so I'm going to be working through the suggestions / changes here.

This is a big PR, but it enables @babel/parser to parse the Smart Pipeline proposal's topic reference. As discussed in babel/proposals#29, this is the first step towards enabling the pipeline plugin to parse and emit all three proposals.

Next, I'll be implementing F#-style parsing, then we'll work on the pipeline plugin itself. I want to get them in piece by piece to avoid merge conflicts. This work had drifted quit a bit, and took me a few days to refresh @js-choi's work with the latest from master, so I'd like to land each piece one by one.

This is a pretty major chunk of work, so definitely interested in getting as much feedback as possible.

🎉One step closer to the landing the pipeline proposals! 🎉

cc @littledan

Fix pipeline types (Implement Smart Pipeline proposal in @babel/parser #8289 (comment))
Reuse tt.hash (if possible)

babel-bot · 2018-07-08T20:13:48Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9434/

nicolo-ribaudo · 2018-07-08T20:51:13Z

Major: Breaking Change? Maybe? (pipelineOperator in @babel/parser now requires proposal option)

Could you move it to a separate PR? Just in case this one doesn't get merged before the Babel 7 RC because it is a huge PR.

mAAdhaTTah · 2018-07-09T00:07:53Z

@nicolo-ribaudo Done! #8291

mAAdhaTTah · 2018-07-10T02:45:15Z

Refreshed from #8291, so this is ready to review again.

nicolo-ribaudo

(I haven’t fully reviewed the PR yet, I didn't mean to approve 😅)

packages/babel-parser/src/parser/expression.js

packages/babel-parser/src/tokenizer/index.js

packages/babel-parser/src/tokenizer/types.js

packages/babel-parser/src/parser/expression.js

packages/babel-parser/src/tokenizer/state.js

packages/babel-parser/src/types.js

nicolo-ribaudo · 2018-07-10T13:25:25Z

Question: are x |> await foo and x |> (await foo) the same thing?

mAAdhaTTah · 2018-07-10T14:01:22Z

Thanks for the review! As for the question

Question: are x |> await foo and x |> (await foo) the same thing?

No; x |> await foo is banned in every proposal, as its semantics are prone to confusion by users. x |> (await foo) desugars to:

const _temp = await foo;
_temp(x);

in every proposal. Smart pipelines enables x |> await foo(#), whereas F# enables x |> foo |> await. Both desugar to await foo(x).

If "smart" proposal is, we'll no longer say.

It's only used once.

mAAdhaTTah · 2018-07-13T03:13:32Z

Just pushed fixes or responses for everything except fixing the Pipeline types, which I have to dig into.

packages/babel-parser/src/parser/expression.js

Set whether we're in a pipeline in order to determine how to parse the hash. The error message changes as a result, since the `hash` never enters the block.

This ensures we clean up always if the callback throws.

This doesn't work because the `type` values are not compatible.

mAAdhaTTah · 2018-07-22T23:00:37Z

I addressed the comments so far, so this is ready for review again.

xtuc · 2018-11-20T18:32:41Z

We can do it in a follow up PR, but we should make sure that https://github.com/babel/babel/blob/master/packages/babel-parser/ast/spec.md keeps updated, we already have the flow definition.

No need to recheck it throughout then.

mAAdhaTTah · 2018-11-21T20:59:42Z

@xtuc Updated as per comments, responded to some of your comments inline. Made a note to update the spec.md.

nicolo-ribaudo

Apart from some minor comments, this PR looks good to me!

packages/babel-parser/src/tokenizer/index.js

nicolo-ribaudo · 2018-11-21T22:36:12Z

packages/babel-parser/src/types.js

+};
+
+export type PipelineStyle =
+  | "PipelineBareFunction"


Is this the only non-node export of this file? I'm not sure that this is the right place where it should be put, but also I can't think of a better place 😕

I mean, the file is called types.js so maybe it's ok?

It's not going to be anything else...

danez

lgtm

existentialism

👍 awesome work!

thiagoarrais · 2018-11-28T16:41:09Z

@mAAdhaTTah: 🍾🍾🍾

mAAdhaTTah · 2018-11-28T16:57:21Z

Thanks so much! I think @xtuc is the last holdout. Any remaining changes you need?

xtuc

LET'S MERGE THIS 🎉 💃

xtuc · 2018-12-03T18:22:39Z

Also thanks for your contribution and sorry if that took so long on our side (or at least mine)!

thiagoarrais · 2018-12-03T18:53:51Z

That's awesome, y'all! I can now get the PR for the transform going.

js-choi · 2018-12-04T01:48:04Z

Thanks everyone for the hard work with the update and review!

mAAdhaTTah mentioned this pull request Jul 9, 2018

Support pipeline proposal flag in @babel/parser #8291

Merged

Implement Smart Pipeline proposal in @babel/parser

fbf62b4

mAAdhaTTah force-pushed the implement-smart-pipeline-in-parser branch from 12da3b9 to fbf62b4 Compare July 10, 2018 02:44

nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser Spec: Pipeline Operator labels Jul 10, 2018

nicolo-ribaudo approved these changes Jul 10, 2018

View reviewed changes

mAAdhaTTah added 8 commits July 12, 2018 22:46

Reverse yoda conditions

ef0f723

If "smart" proposal is, we'll no longer say.

Inline function checkSmartPipelineHeadEarlyErrors

b50fdc1

It's only used once.

Add comment for number sign

0084570

Delete commented code

7188820

Quote proposals in error message

cc52694

Reuse declared type in function return value

e91a02c

Inline readTopicContextState method

b847d40

Rename topicContextState -> .topicContext

7931f4c

nicolo-ribaudo reviewed Jul 13, 2018

View reviewed changes

packages/babel-parser/src/parser/expression.js Outdated Show resolved Hide resolved

nicolo-ribaudo reviewed Jul 13, 2018

View reviewed changes

packages/babel-parser/src/parser/expression.js Outdated Show resolved Hide resolved

mAAdhaTTah added 4 commits July 22, 2018 17:58

Fix TopicContextState type in Flow

6e41edb

Reuse hash token instead of new primaryTopicToken

afd0638

Set whether we're in a pipeline in order to determine how to parse the hash. The error message changes as a result, since the `hash` never enters the block.

Wrap callback in try/finally

094ef31

This ensures we clean up always if the callback throws.

Switch Pipeline types to extend NodeBase

39e7ee6

This doesn't work because the `type` values are not compatible.

mAAdhaTTah force-pushed the implement-smart-pipeline-in-parser branch from baa971f to 39e7ee6 Compare July 22, 2018 22:59

mAAdhaTTah added 2 commits November 21, 2018 15:54

Move plugin check to pipeline op appearance

0eb9b24

No need to recheck it throughout then.

PrimaryTopicReference -> PipelinePrimaryTopicReference

6e84352

s/may/should

70318c9

mAAdhaTTah force-pushed the implement-smart-pipeline-in-parser branch from e6465ef to 70318c9 Compare November 21, 2018 21:02

nicolo-ribaudo approved these changes Nov 21, 2018

View reviewed changes

mAAdhaTTah added 2 commits November 21, 2018 21:05

Hardcode "#" in error message

4cbd22a

It's not going to be anything else...

Replace else with fall through

100b387

nicolo-ribaudo approved these changes Nov 25, 2018

View reviewed changes

danez approved these changes Nov 28, 2018

View reviewed changes

existentialism approved these changes Nov 28, 2018

View reviewed changes

nicolo-ribaudo mentioned this pull request Dec 3, 2018

Add blog post for v7.2.0 babel/website#1906

Merged

xtuc approved these changes Dec 3, 2018

View reviewed changes

xtuc merged commit fdc869c into babel:master Dec 3, 2018

This was referenced Dec 4, 2018

Update @babel/core in /packages/generator/app/templates from 7.1.6 to 7.2.0 JetBrains/ring-ui#518

Merged

Update 2 dependencies from npm JetBrains/ring-ui#519

Merged

thiagoarrais mentioned this pull request Dec 4, 2018

Types for pipeline operator #9122

Merged

gajus mentioned this pull request Dec 6, 2018

Support proposed ES Next "|>" pipeline operator microsoft/TypeScript#17718

Closed

This was referenced Dec 10, 2018

Update @babel/core in / from 7.0.0-beta.32 to 7.2.0 sarhan-azizov/Babel#48

Open

Update @babel/preset-env in / from 7.0.0-beta.32 to 7.2.0 sarhan-azizov/Babel#49

Open

js-choi mentioned this pull request Dec 19, 2018

[smart pipes] Add support for question-mark tokens #9209

Closed

mAAdhaTTah mentioned this pull request Jul 13, 2019

Add Pipeline nodes to ast.spec #10214

Merged

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019

Uh oh!

Conversation

mAAdhaTTah commented Jul 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Jul 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Jul 8, 2018

Uh oh!

mAAdhaTTah commented Jul 9, 2018

Uh oh!

mAAdhaTTah commented Jul 10, 2018

Uh oh!

nicolo-ribaudo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolo-ribaudo commented Jul 10, 2018

Uh oh!

mAAdhaTTah commented Jul 10, 2018

Uh oh!

mAAdhaTTah commented Jul 13, 2018

Uh oh!

Uh oh!

Uh oh!

mAAdhaTTah commented Jul 22, 2018

Uh oh!

xtuc commented Nov 20, 2018

Uh oh!

mAAdhaTTah commented Nov 21, 2018

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nicolo-ribaudo Nov 21, 2018

Choose a reason for hiding this comment

Uh oh!

mAAdhaTTah Nov 22, 2018

Choose a reason for hiding this comment

Uh oh!

danez left a comment

Choose a reason for hiding this comment

Uh oh!

existentialism left a comment

Choose a reason for hiding this comment

Uh oh!

thiagoarrais commented Nov 28, 2018

Uh oh!

mAAdhaTTah commented Nov 28, 2018

Uh oh!

xtuc left a comment

Choose a reason for hiding this comment

Uh oh!

xtuc commented Dec 3, 2018

Uh oh!

thiagoarrais commented Dec 3, 2018

Uh oh!

js-choi commented Dec 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

mAAdhaTTah commented Jul 8, 2018 •

edited

Loading

babel-bot commented Jul 8, 2018 •

edited

Loading

nicolo-ribaudo left a comment •

edited

Loading