Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add docs for plugin-proposal-json-modules#2866

Merged
nicolo-ribaudo merged 5 commits into
babel:mainfrom
nicolo-ribaudo:docs-proposal-json-modules
Feb 28, 2024
Merged

Add docs for plugin-proposal-json-modules#2866
nicolo-ribaudo merged 5 commits into
babel:mainfrom
nicolo-ribaudo:docs-proposal-json-modules

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Feb 26, 2024

@nicolo-ribaudo nicolo-ribaudo added this to the 7.24.0 milestone Feb 26, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 26, 2024

Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit 33c33a6
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/65ddc1c099d2520007930ebb
😎 Deploy Preview https://deploy-preview-2866--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 26, 2024

Deploy Preview for babel ready!

Name Link
🔨 Latest commit 33c33a6
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/65ddc1c06f7f240008d66751
😎 Deploy Preview https://deploy-preview-2866--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add sidebar items to

"TC39 Proposals": [

We can split the group into "stage 3" and "early" as well.

Comment thread docs/plugin-proposal-json-modules.md Outdated
</TabItem>
<TabItem value="node-esm" label="Node.js (ESM)">

```js title="output.js"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
```js title="output.js"
```js title="output.mjs"

will be transformed to

<Tabs>
<TabItem value="browsers" label="Browsers" default>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the preface mentions that "whether the generated code should be compatible with Node.js, browsers, or both", can you add a tab here to show the output when targeting both platforms?

@nicolo-ribaudo nicolo-ribaudo merged commit d9e7aec into babel:main Feb 28, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the docs-proposal-json-modules branch February 28, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants