Add migration docs for removing methods starting with _#2918
Merged
Conversation
👷 Deploy request for babel-next pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for babel ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
JLHwung
reviewed
Jul 9, 2024
|
|
||
| __Migration__: Adapt to the new behaviour. You can use `NodePath#shouldSkip` to check whether a NodePath has been skipped before calling `NodePath#requeue()`. | ||
|
|
||
| - Remove methods starting with `_` ([#16504](https://github.com/babel/babel/pull/16504)) |
Contributor
There was a problem hiding this comment.
Can you prepare a list of removed _-starting methods here? It will help others reach this page from search engines.
Contributor
There was a problem hiding this comment.
Thanks. Nit: Can you sort it alphabetically?
nicolo-ribaudo
approved these changes
Jul 10, 2024
__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: babel/babel#16504
Thanks to babel/babel#16504 (review)