Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adds documentation to README.md #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds documentation to README.md #2

wants to merge 1 commit into from

Conversation

ezra-obiwale
Copy link

  • Creates docker arg PHP_VERSION
  • Removes docker env VERSION

@ezra-obiwale
Adds document to README.md
0d195de 
- Creates docker arg PHP_VERSION
- Removes docker env VERSION
@ezra-obiwale ezra-obiwale changed the title Adds document to README.md Adds documentation to README.md Nov 26, 2024
@bogdannbv
Copy link
Member

Hi @ezra-obiwale , thank you for your contribution!
I had a quick look and one thing that I'm not sure about is extracting the PHP version part of the tag to a build argument, I'd like to have dependabot keep the version up to date and having it as an argument won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezra-obiwale @bogdannbv