Add blink end callback for lighting commands #1214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the specified priority slot after an egress time delay.
…date at the specified priority slot after an egress time delay shall occur.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “blink end” callback mechanism for lighting-command blink/warn operations so WARN_OFF and WARN_RELINQUISH can apply the final Present_Value action (write OFF / relinquish) after the egress-time delay.
Changes:
- Introduces
Blink.CallbackandBlink.Priorityto support end-of-blink actions for WARN_OFF/WARN_RELINQUISH. - Invokes the callback when a blink sequence ends (and when a new command cancels a warn in progress).
- Updates Lighting Output (LO) WARN_OFF/WARN_RELINQUISH handling and extends unit tests + changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| test/bacnet/basic/sys/lighting_command/src/main.c | Extends blink-warn unit tests to cover callback behavior across operations. |
| src/bacnet/basic/sys/lighting_command.h | Adds blink-end callback type + new fields (Priority, Callback) to blink/warn data. |
| src/bacnet/basic/sys/lighting_command.c | Implements callback dispatch and wires it into blink end/cancel paths; stores priority/callback on blink-warn start. |
| src/bacnet/basic/object/lo.c | Uses the new callback to perform delayed OFF/relinquish at the specified priority. |
| CHANGELOG.md | Documents the fix for warn-off/warn-relinquish delayed priority-slot updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a blink end callback for lighting commands to handle updates at specified priority slots after an egress time delay for warn-off and warn-relinquish operations.