Added some options to burst capture mode (see below)#2
Open
TheCapsLock wants to merge 4 commits intobalgamat:masterfrom
Open
Added some options to burst capture mode (see below)#2TheCapsLock wants to merge 4 commits intobalgamat:masterfrom
TheCapsLock wants to merge 4 commits intobalgamat:masterfrom
Conversation
added 4 commits
November 22, 2021 11:34
I added the following options: - captureTarget: allows one to select wether pictures are saved in internal memory or on storage card. Internal memory can be too small to store capture pictures resulting on PTP errors preventing us to do more captures - forceOverwrite: allows overwriting existing files if any (without this and with existing pictures on disk the next captures was failing because gphoto2 requested a user input in interactive shell asking if it is allowed to overwrite existing files) - burstMode: allow using fast or slow burst mode instead of slow mode only
using --wait-event=1s makes gphoto2 terminate after exactly one second regardless if processing is finished. An alternative way is to use string match on CAPTURECOMPLETE action as stated on manpages and https://github.com/gphoto/gphoto2/blob/eab149c6d71c406e2d0ce74028e200b71ceb0601/gphoto2/actions.c#L1228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the following options:
internal memory or on storage card. Internal memory can be too small
to store capture pictures resulting on PTP errors preventing us to do
more captures
and with existing pictures on disk the next captures was failing
because gphoto2 requested a user input in interactive shell asking if it
is allowed to overwrite existing files)
only