Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add source.js scopes#83

Merged
blake-regalia merged 1 commit intomasterfrom
fix-symbols
Dec 27, 2019
Merged

Add source.js scopes#83
blake-regalia merged 1 commit intomasterfrom
fix-symbols

Conversation

@blake-regalia
Copy link
Collaborator

Fixes #82 .

Copy link
Owner

@bathos bathos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I should mention that when I first wrote stuff, I mainly used .es because I thought that .js was ‘claimed’ by the default def and thought that if I used it, it might create collision problems somewhere. I also wasn’t really aware of most of the things that are sensitive to these suffixes. In practice, it’s absences of .js that have led to interop issues a few times, so I likely made the wrong choice.

I don’t know for sure that dropping .es in favor of having .js only would be safe now, but if you think it would make stuff simpler and that it would be safe, maybe it’d be worth it?

Copy link
Collaborator

@dangh dangh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @blake-regalia 🎉

@blake-regalia blake-regalia merged commit 3178393 into master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symbols are not indexed in embedded syntax

3 participants