refactor: move hermetic Python runtime setup into macro #2221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes it easier to understand how it is setup, both for user understanding and future unification of code paths.
aignas
approved these changes
Sep 15, 2024
…o refactor.hermetic.runtime.setup.macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stems from conversation in #2216. Moving the logic into a loading-phase macro makes it
easier to understand how a repo with a python-build-standalone extracted archive has
its toolchain defined. This also makes it easier to compare with the local runtime repo
setup to try and find commonality in the future.
Along the way:
(Bazel 5 support was dropped earlier this year and we stopped testing with it; it's
likely already broken with Bazel 5).
semver.to_dict, which makes it easier to pass into format() functions.