Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Add libdir to library search path #2476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 7, 2025
Merged

fix: Add libdir to library search path #2476

merged 4 commits into from
Mar 7, 2025

Conversation

shs96c
Copy link
Contributor

@shs96c shs96c commented Dec 6, 2024

We discovered when dealing with libraries such as psycopg2 that the wheel would attempt to link against libpython.a. This fix points the linker at the correct python version being used.

aignas
aignas reviewed Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is gated by a feature toggle, it seems to be low risk to include.

@rickeylev
Copy link
Collaborator

Just want to respond to something the comment says:

# [calling the python interpreter in repo-phase]
# is super hacky, but working out something nice is tricky.
# This is in particular needed for psycopg2 which attempts to link libpython.a,
# in order to point the linker at the correct python intepreter.

It's not possible to reliably get the correct Python interpreter. This is because the repo phase doesn't know, and can't know, what the build phase is going to do (i.e. what python interpreter will be used). The basic change in this PR is somewhat an improvement, but yeah -- just wanted to point out it'll still be prone to issues. To really fix this, the sdist building needs to move into the build phase.

@aignas
Copy link
Collaborator

aignas commented Dec 8, 2024

I'll add some ideas about this in #2410.

@shs96c
Copy link
Contributor Author

shs96c commented Dec 19, 2024

Is there anything else you'd like me to do for this PR?

@aignas aignas enabled auto-merge March 7, 2025 04:56
@aignas aignas added this pull request to the merge queue Mar 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 7, 2025
@aignas aignas added this pull request to the merge queue Mar 7, 2025
Merged via the queue into bazel-contrib:main with commit e7d2f09 Mar 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shs96c @rickeylev @aignas