refactor: consolidate py_executable_bazel, common_bazel #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move convert_legacy_create_init_to_int to py_executable as it's only relevant to executables
aignas
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This furthers the work of removing the artificial split of code that stemmed from
when the implementation was part of Bazel itself. Summary of changes:
py_executable_bazel.bzlintopy_executable.bzlcommon_bazel.bzlintocommon.bzlprecompile.bzlfor the precompile helpers. This is to avoid acircular dependency between common.bzl and attributes.bzl.
Work towards #2522