Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: using python_version attribute for specifying python version #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

docs: using python_version attribute for specifying python version #2589

merged 2 commits into from
Jan 28, 2025

Conversation

JeroenSchmidt
Copy link
Contributor

@JeroenSchmidt JeroenSchmidt commented Jan 28, 2025 •
edited by rickeylev
Loading

Updates examples and docs to tell to use the base rules and the python_version attribute
instead of the wrapper transition rules.

@JeroenSchmidt JeroenSchmidt mentioned this pull request Jan 28, 2025
Closed
@JeroenSchmidt JeroenSchmidt changed the title docs: prefer python_version attribute for specifying python version docs: using python_version attribute for specifying python version Jan 28, 2025
rickeylev
rickeylev approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They didn't permit those trivial/mechanical changes to BUILD.bazel? Well, ok then.

We still appreciate your doc contributions!

@rickeylev rickeylev added this pull request to the merge queue Jan 28, 2025
Merged via the queue into bazel-contrib:main with commit 466da1d Jan 28, 2025
3 checks passed
@JeroenSchmidt
Copy link
Contributor Author

JeroenSchmidt commented Jan 29, 2025 •
edited
Loading

Hi @rickeylev

I left out examples/multi_python_versions/tests/BUILD.bazel because I thought it was updated in #2569 and due to the comment in the last PR. I can open another one for that BUILD file if it's still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

@aignas aignas Awaiting requested review from aignas aignas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeroenSchmidt @rickeylev