Thanks to visit codestin.com
Credit goes to github.com

Skip to content

py_wheel: always generate zip64-capable wheels #2711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 3, 2025
Merged

py_wheel: always generate zip64-capable wheels #2711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
00765de
feat: Add force_zip64 option
devtbi Mar 26, 2025
bd36934
always set forceZip64=True
rickeylev Apr 20, 2025
3e90a1f
remove passing zip64 as cli
rickeylev Apr 20, 2025
134750a
Merge branch 'main' into main
rickeylev Apr 20, 2025
bd0114f
Merge branch 'main' into main
rickeylev May 2, 2025
9ab56c2
Update hash
rickeylev May 2, 2025
ed95960
Fix more hashes
rickeylev May 3, 2025
624e040
Fix another hash
rickeylev May 3, 2025
cf9e3dd
Fix test_publish hash
rickeylev May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,14 @@ END_UNRELEASED_TEMPLATE

{#v0-0-0-changed}
### Changed

* (rules) On Windows, {obj}`--bootstrap_impl=system_python` is forced. This
allows setting `--bootstrap_impl=script` in bazelrc for mixed-platform
environments.
* (rules) {obj}`pip_compile` now generates a `.test` target. The `_test` target is deprecated
and will be removed in the next major release.
([#2794](https://github.com/bazel-contrib/rules_python/issues/2794)
* (py_wheel) py_wheel always creates zip64-capable wheel zips

{#v0-0-0-fixed}
### Fixed
Expand Down
2 changes: 1 addition & 1 deletion examples/wheel/test_publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def test_upload_and_query_simple_api(self):
</head>
<body>
<h1>Links for example-minimal-library</h1>
<a href="/packages/example_minimal_library-0.0.1-py3-none-any.whl#sha256=a73acae23590c7a8d4365c888c1f12f0399b7af27169ea99fc7a00f402833926">example_minimal_library-0.0.1-py3-none-any.whl</a><br>
<a href="/packages/example_minimal_library-0.0.1-py3-none-any.whl#sha256=ef5afd9f6c3ff569ef7e5b2799d3a2ec9675d029414f341e0abd7254d6b9a25d">example_minimal_library-0.0.1-py3-none-any.whl</a><br>
</body>
</html>"""
self.assertEqual(
Expand Down
16 changes: 8 additions & 8 deletions examples/wheel/wheel_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_py_library_wheel(self):
],
)
self.assertFileSha256Equal(
filename, "a73acae23590c7a8d4365c888c1f12f0399b7af27169ea99fc7a00f402833926"
filename, "ef5afd9f6c3ff569ef7e5b2799d3a2ec9675d029414f341e0abd7254d6b9a25d"
)

def test_py_package_wheel(self):
Expand All @@ -110,7 +110,7 @@ def test_py_package_wheel(self):
],
)
self.assertFileSha256Equal(
filename, "a76001500453dbd1d778821dcaba165d56db502c854cef9381dd3f8f89caee11"
filename, "39bec133cf79431e8d057eae550cd91aa9dfbddfedb53d98ebd36e3ade2753d0"
)

def test_customized_wheel(self):
Expand Down Expand Up @@ -206,7 +206,7 @@ def test_customized_wheel(self):
second = second.main:s""",
)
self.assertFileSha256Equal(
filename, "941c0d79f4ca67cfa0028248bd0606db7fc69953ff9c7c73ac26a3e6d3c23587"
filename, "685f68fc6665f53c9b769fd1ba12cce9937ab7f40ef4e60c82ef2de8653935de"
)

def test_filename_escaping(self):
Expand Down Expand Up @@ -278,7 +278,7 @@ def test_custom_package_root_wheel(self):
for line in record_contents.splitlines():
self.assertFalse(line.startswith("/"))
self.assertFileSha256Equal(
filename, "7bd959b7efe9e325b30a6559177a1a4f22ac7a68fade310845916276110e9287"
filename, "2fbfc3baaf6fccca0f97d02316b8344507fe6c8136991a66ee5f162235adb19f"
)

def test_custom_package_root_multi_prefix_wheel(self):
Expand Down Expand Up @@ -312,7 +312,7 @@ def test_custom_package_root_multi_prefix_wheel(self):
for line in record_contents.splitlines():
self.assertFalse(line.startswith("/"))
self.assertFileSha256Equal(
filename, "caf51e22bdcd3c6c766c8903319ce717daeb6caac577d14e16326a8597981854"
filename, "3e67971ca1e8a9ba36a143df7532e641f5661c56235e41d818309316c955ba58"
)

def test_custom_package_root_multi_prefix_reverse_order_wheel(self):
Expand Down Expand Up @@ -346,7 +346,7 @@ def test_custom_package_root_multi_prefix_reverse_order_wheel(self):
for line in record_contents.splitlines():
self.assertFalse(line.startswith("/"))
self.assertFileSha256Equal(
filename, "9e8c0baa408b829dec691a5e8d3bc040be0bbfcc95c0eee19e1e5ffadea4a059"
filename, "372ef9e11fb79f1952172993718a326b5adda192d94884b54377c34b44394982"
)

def test_python_requires_wheel(self):
Expand All @@ -371,7 +371,7 @@ def test_python_requires_wheel(self):
""",
)
self.assertFileSha256Equal(
filename, "b47f3eaf4f9fa4685a58c7415ba1feddd39635ae26c18473504f7d7e62e8ce07"
filename, "10a325ba8f77428b5cfcff6345d508f5eb77c140889eb62490d7382f60d4ebfe"
)

def test_python_abi3_binary_wheel(self):
Expand Down Expand Up @@ -436,7 +436,7 @@ def test_rule_creates_directory_and_is_included_in_wheel(self):
],
)
self.assertFileSha256Equal(
filename, "d8e874b807e5574bd11a9312c58ce7fe7055afb80412d0d0e7ed21fc9223cd53"
filename, "85e44c43cc19ccae9fe2e1d629230203aa11791bed1f7f68a069fb58d1c93cd2"
)

def test_rule_expands_workspace_status_keys_in_wheel_metadata(self):
Expand Down
2 changes: 1 addition & 1 deletion tools/wheelmaker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ def arcname_from(name):
hash = hashlib.sha256()
size = 0
with open(real_filename, "rb") as fsrc:
with self.open(zinfo, "w") as fdst:
with self.open(zinfo, "w", force_zip64=True) as fdst:
while True:
block = fsrc.read(2**20)
if not block:
Expand Down