Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: compare Starlark and Python deps parsing for host_plat #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented May 2, 2025

WIP: This PR is probably not fully done and I am creating this so that the
contributors can collaborate.

I was thinking how we can start enabling the starlark implementation and roll
it out for more and more packages and for that we need more testing and this
test goes like following:

  1. Call Simple API for top 500 packages.
  2. Get the latest version wheel.
  3. Use the Simple API to get the URL of the METADATA file only and its sha256.
  4. Call the Python code to get the deps.
  5. Parse METADATA file with Starlark and dump the requires_dist to a bzl
    file.
  6. In a rules_testing test, run the Starlark implementation of deps parsing
    and compare it with the results we are getting for the Python
    implementation.

Once we have sufficient amount of testing done on all platforms our CI has, we
can think of how we can continue improving this. Some ideas:

  • Cover more versions of the same wheel.
  • Add particular wheels that are problematic.

This can hopefully be a tool to compare and debug problematic cases where we
need to understand what is going on and add a regression test to the Starlark
implementation.

Work towards #260, #2826

@aignas aignas requested review from rickeylev and groodt as code owners May 2, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant