fix: Make local runtime repo work on Windows #2862
Conversation
In particular, this fixes two problems: First, windows requires interface libraries to be linked in. Second, windows requires an alternative search path since LIBDIR is not filled in.
234eec5 to
201e2d4
Compare
|
Hi @rickeylev. Thanks for adding local_runtime_repo, but it doesn't seem to work on windows. Here is a fix that seems to work both locally on my machine and in github actions (https://github.com/som-shahlab/meds_reader is my repository using the fixed rules to enable Windows builds). Can you take a look at this PR and help me get this merged? I'm not sure why it's failing the rules_python build checks. Thanks! |
|
Thanks for the PR! PRs improving support on Windows are always welcome. Could you please:
EDIT: since the local runtime repo should be now supported by all the platforms that the CI runs on, would it be possible to add a test so that this does not regress in the future? |
There was a problem hiding this comment.
Yeah, I didn't try any of this with Windows, so thanks for this, @EthanSteinberg.
Mostly LGTM, but a few small changes requested.
re: adding a test: Yeah, a basic test for this would be good.
The place for the test would be in tests/integration/local_toolchains
Oddly, I don't see any windows exclusions for that? But, I would expect the windows CI to fail if it was running. So there must be a tag or something I'm missing.
In any case -- modifying tests/integration/local_toolchains/MODULE.bazel to have a windows section is the thing to do. You can cd into that directory and run bazel to improve your edit/run loop.
|
@aignas @rickeylev Thanks for the suggestions. It's a good call to add a test and it should be added before this is merged. I would be a bit worried about having this fragile functionality without a good CI test. I have figured out why the current tests aren't working:
Let me look into both of the above this weekend. |
fix: Make local runtime repo work on windows
In particular, this fixes two problems:
First, windows requires interface libraries to be linked in.
Second, windows requires an alternative search path (LIBDEST) since LIBDIR is not filled in.