refactor: have bzlmod pass platforms to python_register_toolchains #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of using global
aignas
approved these changes
May 17, 2025
| @@ -149,6 +149,7 @@ def _test_default(env): | |||
| "base_url", | |||
| "ignore_root_user_error", | |||
| "tool_versions", | |||
| "platforms", | |||
There was a problem hiding this comment.
Ah, so this does not expose any extra APIs yet, so hence no extra tests here, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to facilitate eventually allowing overrides to add additional platforms.
Instead of the PLATFORMS global being used, the python bzlmod extension passing the
mapping directly to python_register_toolchains, then receives back the subset of
platforms that had repos defined. That subset is then later used when (re)constructing
the list of repo names for the toolchains.