feat(gazelle) Remove entry point file requirements when generating rules #2998
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougthor42
reviewed
Jun 21, 2025
dougthor42
reviewed
Jun 21, 2025
852d647 to
3ae39ee
Compare
yushan26
commented
Jun 24, 2025
| @@ -0,0 +1 @@ | |||
| # gazelle:python_generation_mode project | |||
There was a problem hiding this comment.
This is an existing test that is testing if subdirectory srcs gets added to a py_library target. Subdirectory sources will only be added to a py_library target in project mode.
|
@dougthor42 please take another look |
dougthor42
approved these changes
Jul 1, 2025
dougthor42
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove entry point file requirements when generating rules. Enable python rule generation as long as there are .py source files under the directory so all new packages will have python rules generated in the package.
The extension used to require entrypoints for generation but:
__test__.py) is no longer required after generate py_test without __test__ #999 and feat!: Following generation mode when generating test targets #2044__main__.py) is no longer required after feat: Creating one py_binary per main module #1584The entry point for libraries (
__init__.py) shouldn't be required either, especially for Python 3.3 and after when namespace packages are supported.